You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mynewt.apache.org by Vipul Rahane <vi...@runtime.io> on 2016/04/06 22:45:16 UTC

hal_gpio_toggle() should return changed pin state

Hello,

Current definition: void hal_gpio_toggle() doesn’t return anything. 
Proposed definition: int hal_gpio_toggle(). I want to do this so that it returns the pins changed state. I would like to make this change so that we know what the gpio is actually set to.

Both ways we do hal_gpio_read(). Thoughts ?

Regards,
Vipul Rahane

Re: hal_gpio_toggle() should return changed pin state

Posted by "paul@wrada.com" <pa...@wrada.com>.

Sound good to me 

> On Apr 6, 2016, at 3:10 PM, will sanfilippo <wi...@runtime.io> wrote:
> 
> Seems fine to me.
> 
> 
>> On Apr 6, 2016, at 1:45 PM, Vipul Rahane <vi...@runtime.io> wrote:
>> 
>> Hello,
>> 
>> Current definition: void hal_gpio_toggle() doesn’t return anything. 
>> Proposed definition: int hal_gpio_toggle(). I want to do this so that it returns the pins changed state. I would like to make this change so that we know what the gpio is actually set to.
>> 
>> Both ways we do hal_gpio_read(). Thoughts ?
>> 
>> Regards,
>> Vipul Rahane
>

Re: hal_gpio_toggle() should return changed pin state

Posted by will sanfilippo <wi...@runtime.io>.

Seems fine to me.


> On Apr 6, 2016, at 1:45 PM, Vipul Rahane <vi...@runtime.io> wrote:
> 
> Hello,
> 
> Current definition: void hal_gpio_toggle() doesn’t return anything. 
> Proposed definition: int hal_gpio_toggle(). I want to do this so that it returns the pins changed state. I would like to make this change so that we know what the gpio is actually set to.
> 
> Both ways we do hal_gpio_read(). Thoughts ?
> 
> Regards,
> Vipul Rahane