[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5289: Mpfs bootloader entrypoints

[GitBox <gi...@apache.org>]

pkarashchenko commented on a change in pull request #5289:
URL: https://github.com/apache/incubator-nuttx/pull/5289#discussion_r788732453



##########
File path: arch/risc-v/src/mpfs/Kconfig
##########
@@ -58,6 +58,66 @@ config MPFS_OPENSBI
         ---help---
                 This uses a ld-envm-opensbi.script linker script and the mpfs_opensbi.c code to use external OpenSBI.
 
+config MPFS_HART0_SBI
+	bool "HART0 boots via SBI"
+	depends on MPFS_OPENSBI
+	default n
+
+config MPFS_HART1_SBI
+	bool "HART1 boots via SBI"
+	depends on MPFS_OPENSBI
+	default n
+
+config MPFS_HART2_SBI
+	bool "HART2 boots via SBI"
+	depends on MPFS_OPENSBI
+	default n
+
+config MPFS_HART3_SBI
+	bool "HART3 boots via SBI"
+	depends on MPFS_OPENSBI
+	default n
+
+config MPFS_HART4_SBI
+	bool "HART4 boots via SBI"
+	depends on MPFS_OPENSBI
+	default n
+
+config MPFS_HART0_ENTRYPOINT
+	hex "Application entry point for HART0"
+	depends on MPFS_BOOTLOADER
+	default 0xFFFFFFFFFFFFFFFF

Review comment:
       Could you please use lower case? I see that upper case is used only in one file https://github.com/apache/incubator-nuttx/blob/master/boards/arm/cxd56xx/spresense/Kconfig and other use lower case. I will make a PR to change `spresense/Kconfig` to  lower case




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org