You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2021/10/02 20:23:46 UTC
[GitHub] [ant] arturobernalg opened a new pull request #164: Use inner class as static.
arturobernalg opened a new pull request #164:
URL: https://github.com/apache/ant/pull/164
Its not require access to an enclosing instance's non-public fields and methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #164: Use inner class as static.
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #164:
URL: https://github.com/apache/ant/pull/164#issuecomment-932924639
Thank you @arturobernalg but I'm afraid this is a change that is not backwards compatible at all so we cannot accept it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] arturobernalg closed pull request #164: Use inner class as static.
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #164:
URL: https://github.com/apache/ant/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on a change in pull request #164: Use inner class as static.
Posted by GitBox <gi...@apache.org>.
bodewig commented on a change in pull request #164:
URL: https://github.com/apache/ant/pull/164#discussion_r720811236
##########
File path: src/main/org/apache/tools/ant/taskdefs/Javac.java
##########
@@ -910,7 +910,7 @@ public boolean getNowarn() {
*/
public ImplementationSpecificArgument createCompilerArg() {
final ImplementationSpecificArgument arg =
- new ImplementationSpecificArgument();
+ new ImplementationSpecificArgument();
Review comment:
please don't change whitespace in existing code.
##########
File path: src/main/org/apache/tools/ant/taskdefs/Input.java
##########
@@ -44,7 +44,7 @@
/**
* Represents an InputHandler.
*/
- public class Handler extends DefBase {
+ public static class Handler extends DefBase {
Review comment:
this change is not backwards compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] arturobernalg commented on pull request #164: Use inner class as static.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #164:
URL: https://github.com/apache/ant/pull/164#issuecomment-932934366
> Thank you @arturobernalg but I'm afraid this is a change that is not backwards compatible at all so we cannot accept it.
HI @bodewig
Ok, close the PR. maybe for a new. mayor release.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #164: Use inner class as static.
Posted by GitBox <gi...@apache.org>.
bodewig commented on pull request #164:
URL: https://github.com/apache/ant/pull/164#issuecomment-932935464
for historical reasons Ant is not following semantic versioning, so the next "major release" would be 1.11.0. Having said that I'm not aware of anybody planning to create such a thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org