You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/03/16 12:28:03 UTC
Review Request 32098: Cleanup right angle bracket in test code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32098/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1872
https://issues.apache.org/jira/browse/MESOS-1872
Repository: mesos
Description
-------
Cleanup right angle bracket in test code.
Diffs
-----
src/tests/authentication_tests.cpp 5126ed4acbdf4c8508133bed35f98b0da3cca11e
src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87
src/tests/cgroups_tests.cpp 75c61aad80f894acb92a9752e8d1b6af70e5b9a6
src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec
src/tests/composing_containerizer_tests.cpp d66f5198114c7bd67107ee056c2062d3118d1b4c
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/containerizer.cpp 26b87ac6b16dfeaf84888e80296ef540697bd775
src/tests/containerizer_tests.cpp 565903b754bbf5891891b183a283aee038eb1b8f
src/tests/credentials_tests.cpp ed672733ff895b1f252fa75d5653a9f3527d5b5f
src/tests/disk_quota_tests.cpp 9c3a8815c3478535b72888c296a4aa5cda341ba3
src/tests/docker_containerizer_tests.cpp 06cd3d89ecbaaac17ae6970604b21fbe29f6e887
src/tests/docker_tests.cpp 5520c5849614db7a410c33be38975a5f7dc92b63
src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17
src/tests/exception_tests.cpp 9af16748ae67671bd327a1ea7c946a7a38c5f7ff
src/tests/external_containerizer_test.cpp ca6fe503c33ba7c537803cf9a88a79d7584502de
src/tests/fault_tolerance_tests.cpp 9ac75b1f601e14a3d3d117775f37a4a48b291dc6
src/tests/gc_tests.cpp deaa6b1b6c32ae6d153229248d7d4f57caa0ebcf
src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c
src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
src/tests/isolator.hpp 93537cb7f82ff0e44e0b53b3453fdd4879493435
src/tests/isolator_tests.cpp 09364363cf5c9c8fa615a5ed449fbd0a78ffc5ec
src/tests/launcher.hpp 81ae95c91b5baf11bac3da0c9317981242accd37
src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e
src/tests/master_allocator_tests.cpp a432d0207e1a92532a495bf9ad2826414ee4f6f0
src/tests/master_authorization_tests.cpp ff706ed6f8537207b30a548b0ce2121c5df71ab9
src/tests/master_contender_detector_tests.cpp 3108b9421c7378c8b6dbda1bea4c98a2c43dff5f
src/tests/master_slave_reconciliation_tests.cpp e60f601202fcdbb4cafac190e9b09ca6ce925260
src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
src/tests/mesos.cpp c8f43d21b214e75eaac2870cbdf4f03fd18707d1
src/tests/partition_tests.cpp bb96aed37861867fbde68445016f0c6e039f3fb4
src/tests/perf_tests.cpp 16f32267f694ccaae9d10c2629831e2cca23e0c8
src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96
src/tests/rate_limiting_tests.cpp d5c00b8db30fc529bc984417a632cf99eb50eb28
src/tests/reconciliation_tests.cpp acd70021574b05ab23872add5bdfa4a46b7dfc51
src/tests/registrar_tests.cpp ebcce73b627b3cee044bf239c4d3ba9753a8fa73
src/tests/registrar_zookeeper_tests.cpp 42bc2a2e7dbbbda8e09ec71c73bbf95583717851
src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66
src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba
src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
src/tests/shutdown_tests.cpp b3e999ee2809bab1e083851ca3fbe21776fd0321
src/tests/slave_recovery_tests.cpp 53adae0118a26e6d25a9ff20c6374cc8e73275b1
src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22
src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58
src/tests/status_update_manager_tests.cpp 216a22e9f292b4141c8b966dad0f25dbd791c025
src/tests/zookeeper.cpp 08cab86d148edf0cae3aaebfda30c21a75bca2b2
src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85
Diff: https://reviews.apache.org/r/32098/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32098: Cleanup right angle bracket in test code.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32098/#review76553
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32098]
All tests passed.
- Mesos ReviewBot
On March 16, 2015, 12:49 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32098/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 12:49 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1872
> https://issues.apache.org/jira/browse/MESOS-1872
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleanup right angle bracket in test code.
>
>
> Diffs
> -----
>
> src/tests/authentication_tests.cpp 5126ed4acbdf4c8508133bed35f98b0da3cca11e
> src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87
> src/tests/cgroups_tests.cpp 75c61aad80f894acb92a9752e8d1b6af70e5b9a6
> src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec
> src/tests/composing_containerizer_tests.cpp d66f5198114c7bd67107ee056c2062d3118d1b4c
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/containerizer.cpp 26b87ac6b16dfeaf84888e80296ef540697bd775
> src/tests/containerizer_tests.cpp 565903b754bbf5891891b183a283aee038eb1b8f
> src/tests/credentials_tests.cpp ed672733ff895b1f252fa75d5653a9f3527d5b5f
> src/tests/disk_quota_tests.cpp 9c3a8815c3478535b72888c296a4aa5cda341ba3
> src/tests/docker_containerizer_tests.cpp 06cd3d89ecbaaac17ae6970604b21fbe29f6e887
> src/tests/docker_tests.cpp 5520c5849614db7a410c33be38975a5f7dc92b63
> src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17
> src/tests/exception_tests.cpp 9af16748ae67671bd327a1ea7c946a7a38c5f7ff
> src/tests/external_containerizer_test.cpp ca6fe503c33ba7c537803cf9a88a79d7584502de
> src/tests/fault_tolerance_tests.cpp 9ac75b1f601e14a3d3d117775f37a4a48b291dc6
> src/tests/gc_tests.cpp deaa6b1b6c32ae6d153229248d7d4f57caa0ebcf
> src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c
> src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
> src/tests/isolator.hpp 93537cb7f82ff0e44e0b53b3453fdd4879493435
> src/tests/isolator_tests.cpp 09364363cf5c9c8fa615a5ed449fbd0a78ffc5ec
> src/tests/launcher.hpp 81ae95c91b5baf11bac3da0c9317981242accd37
> src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e
> src/tests/master_allocator_tests.cpp a432d0207e1a92532a495bf9ad2826414ee4f6f0
> src/tests/master_authorization_tests.cpp ff706ed6f8537207b30a548b0ce2121c5df71ab9
> src/tests/master_contender_detector_tests.cpp 3108b9421c7378c8b6dbda1bea4c98a2c43dff5f
> src/tests/master_slave_reconciliation_tests.cpp e60f601202fcdbb4cafac190e9b09ca6ce925260
> src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
> src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
> src/tests/mesos.cpp c8f43d21b214e75eaac2870cbdf4f03fd18707d1
> src/tests/partition_tests.cpp bb96aed37861867fbde68445016f0c6e039f3fb4
> src/tests/perf_tests.cpp 16f32267f694ccaae9d10c2629831e2cca23e0c8
> src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96
> src/tests/rate_limiting_tests.cpp d5c00b8db30fc529bc984417a632cf99eb50eb28
> src/tests/reconciliation_tests.cpp acd70021574b05ab23872add5bdfa4a46b7dfc51
> src/tests/registrar_tests.cpp ebcce73b627b3cee044bf239c4d3ba9753a8fa73
> src/tests/registrar_zookeeper_tests.cpp 42bc2a2e7dbbbda8e09ec71c73bbf95583717851
> src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66
> src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba
> src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
> src/tests/shutdown_tests.cpp b3e999ee2809bab1e083851ca3fbe21776fd0321
> src/tests/slave_recovery_tests.cpp 53adae0118a26e6d25a9ff20c6374cc8e73275b1
> src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22
> src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58
> src/tests/status_update_manager_tests.cpp 216a22e9f292b4141c8b966dad0f25dbd791c025
> src/tests/zookeeper.cpp 08cab86d148edf0cae3aaebfda30c21a75bca2b2
> src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85
>
> Diff: https://reviews.apache.org/r/32098/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32098: Cleanup right angle bracket in test code.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32098/
-----------------------------------------------------------
(Updated March 16, 2015, 12:49 p.m.)
Review request for mesos.
Bugs: MESOS-1872
https://issues.apache.org/jira/browse/MESOS-1872
Repository: mesos
Description
-------
Cleanup right angle bracket in test code.
Diffs (updated)
-----
src/tests/authentication_tests.cpp 5126ed4acbdf4c8508133bed35f98b0da3cca11e
src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87
src/tests/cgroups_tests.cpp 75c61aad80f894acb92a9752e8d1b6af70e5b9a6
src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec
src/tests/composing_containerizer_tests.cpp d66f5198114c7bd67107ee056c2062d3118d1b4c
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/containerizer.cpp 26b87ac6b16dfeaf84888e80296ef540697bd775
src/tests/containerizer_tests.cpp 565903b754bbf5891891b183a283aee038eb1b8f
src/tests/credentials_tests.cpp ed672733ff895b1f252fa75d5653a9f3527d5b5f
src/tests/disk_quota_tests.cpp 9c3a8815c3478535b72888c296a4aa5cda341ba3
src/tests/docker_containerizer_tests.cpp 06cd3d89ecbaaac17ae6970604b21fbe29f6e887
src/tests/docker_tests.cpp 5520c5849614db7a410c33be38975a5f7dc92b63
src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17
src/tests/exception_tests.cpp 9af16748ae67671bd327a1ea7c946a7a38c5f7ff
src/tests/external_containerizer_test.cpp ca6fe503c33ba7c537803cf9a88a79d7584502de
src/tests/fault_tolerance_tests.cpp 9ac75b1f601e14a3d3d117775f37a4a48b291dc6
src/tests/gc_tests.cpp deaa6b1b6c32ae6d153229248d7d4f57caa0ebcf
src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c
src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
src/tests/isolator.hpp 93537cb7f82ff0e44e0b53b3453fdd4879493435
src/tests/isolator_tests.cpp 09364363cf5c9c8fa615a5ed449fbd0a78ffc5ec
src/tests/launcher.hpp 81ae95c91b5baf11bac3da0c9317981242accd37
src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e
src/tests/master_allocator_tests.cpp a432d0207e1a92532a495bf9ad2826414ee4f6f0
src/tests/master_authorization_tests.cpp ff706ed6f8537207b30a548b0ce2121c5df71ab9
src/tests/master_contender_detector_tests.cpp 3108b9421c7378c8b6dbda1bea4c98a2c43dff5f
src/tests/master_slave_reconciliation_tests.cpp e60f601202fcdbb4cafac190e9b09ca6ce925260
src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
src/tests/mesos.cpp c8f43d21b214e75eaac2870cbdf4f03fd18707d1
src/tests/partition_tests.cpp bb96aed37861867fbde68445016f0c6e039f3fb4
src/tests/perf_tests.cpp 16f32267f694ccaae9d10c2629831e2cca23e0c8
src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96
src/tests/rate_limiting_tests.cpp d5c00b8db30fc529bc984417a632cf99eb50eb28
src/tests/reconciliation_tests.cpp acd70021574b05ab23872add5bdfa4a46b7dfc51
src/tests/registrar_tests.cpp ebcce73b627b3cee044bf239c4d3ba9753a8fa73
src/tests/registrar_zookeeper_tests.cpp 42bc2a2e7dbbbda8e09ec71c73bbf95583717851
src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66
src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba
src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
src/tests/shutdown_tests.cpp b3e999ee2809bab1e083851ca3fbe21776fd0321
src/tests/slave_recovery_tests.cpp 53adae0118a26e6d25a9ff20c6374cc8e73275b1
src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22
src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58
src/tests/status_update_manager_tests.cpp 216a22e9f292b4141c8b966dad0f25dbd791c025
src/tests/zookeeper.cpp 08cab86d148edf0cae3aaebfda30c21a75bca2b2
src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85
Diff: https://reviews.apache.org/r/32098/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32098: Cleanup right angle bracket in test code.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32098/
-----------------------------------------------------------
(Updated March 16, 2015, 12:36 p.m.)
Review request for mesos.
Bugs: MESOS-1872
https://issues.apache.org/jira/browse/MESOS-1872
Repository: mesos
Description
-------
Cleanup right angle bracket in test code.
Diffs (updated)
-----
src/tests/authentication_tests.cpp 5126ed4acbdf4c8508133bed35f98b0da3cca11e
src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87
src/tests/cgroups_tests.cpp 75c61aad80f894acb92a9752e8d1b6af70e5b9a6
src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec
src/tests/composing_containerizer_tests.cpp d66f5198114c7bd67107ee056c2062d3118d1b4c
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/containerizer.cpp 26b87ac6b16dfeaf84888e80296ef540697bd775
src/tests/containerizer_tests.cpp 565903b754bbf5891891b183a283aee038eb1b8f
src/tests/credentials_tests.cpp ed672733ff895b1f252fa75d5653a9f3527d5b5f
src/tests/disk_quota_tests.cpp 9c3a8815c3478535b72888c296a4aa5cda341ba3
src/tests/docker_containerizer_tests.cpp 06cd3d89ecbaaac17ae6970604b21fbe29f6e887
src/tests/docker_tests.cpp 5520c5849614db7a410c33be38975a5f7dc92b63
src/tests/environment.cpp e002363f8fbc63936211ff4c2dd36bfc5b452d17
src/tests/exception_tests.cpp 9af16748ae67671bd327a1ea7c946a7a38c5f7ff
src/tests/external_containerizer_test.cpp ca6fe503c33ba7c537803cf9a88a79d7584502de
src/tests/fault_tolerance_tests.cpp 9ac75b1f601e14a3d3d117775f37a4a48b291dc6
src/tests/gc_tests.cpp deaa6b1b6c32ae6d153229248d7d4f57caa0ebcf
src/tests/group_tests.cpp 13e89c33617997aac2024a3de7beedb2fb28e03c
src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
src/tests/isolator.hpp 93537cb7f82ff0e44e0b53b3453fdd4879493435
src/tests/isolator_tests.cpp 09364363cf5c9c8fa615a5ed449fbd0a78ffc5ec
src/tests/launcher.hpp 81ae95c91b5baf11bac3da0c9317981242accd37
src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e
src/tests/master_allocator_tests.cpp a432d0207e1a92532a495bf9ad2826414ee4f6f0
src/tests/master_authorization_tests.cpp ff706ed6f8537207b30a548b0ce2121c5df71ab9
src/tests/master_contender_detector_tests.cpp 3108b9421c7378c8b6dbda1bea4c98a2c43dff5f
src/tests/master_slave_reconciliation_tests.cpp e60f601202fcdbb4cafac190e9b09ca6ce925260
src/tests/master_tests.cpp e69348be676a80017062e3abbd15b8008a6009d7
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
src/tests/mesos.cpp c8f43d21b214e75eaac2870cbdf4f03fd18707d1
src/tests/partition_tests.cpp bb96aed37861867fbde68445016f0c6e039f3fb4
src/tests/perf_tests.cpp 16f32267f694ccaae9d10c2629831e2cca23e0c8
src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96
src/tests/rate_limiting_tests.cpp d5c00b8db30fc529bc984417a632cf99eb50eb28
src/tests/reconciliation_tests.cpp acd70021574b05ab23872add5bdfa4a46b7dfc51
src/tests/registrar_tests.cpp ebcce73b627b3cee044bf239c4d3ba9753a8fa73
src/tests/registrar_zookeeper_tests.cpp 42bc2a2e7dbbbda8e09ec71c73bbf95583717851
src/tests/repair_tests.cpp 4d513ed9e18ebf04a5e5aadb022b064479739e66
src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba
src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657
src/tests/shutdown_tests.cpp b3e999ee2809bab1e083851ca3fbe21776fd0321
src/tests/slave_recovery_tests.cpp 53adae0118a26e6d25a9ff20c6374cc8e73275b1
src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22
src/tests/state_tests.cpp b8cddc5fa530aa465d5575e0136e9c89c2b04b58
src/tests/status_update_manager_tests.cpp 216a22e9f292b4141c8b966dad0f25dbd791c025
src/tests/zookeeper.cpp 08cab86d148edf0cae3aaebfda30c21a75bca2b2
src/tests/zookeeper_tests.cpp 7d1c0665f06e067637861424aa647d6e4d3f9c85
Diff: https://reviews.apache.org/r/32098/diff/
Testing
-------
make check
Thanks,
Joerg Schad