[GitHub] eiri opened a new pull request #1090: Cleanup data dirs in eunit_plugin before test run

[GitBox <gi...@apache.org>]

eiri opened a new pull request #1090: Cleanup data dirs in eunit_plugin before test run
URL: https://github.com/apache/couchdb/pull/1090
 
 
   ## Overview
   
   We are using `unique_monotonic_integer` to name the test databases in unit testing. That means that on erlang R > 18 we are always creating databases with the same names.
   
   When a unit tests crashing or suites don't cleaning up on teardown, they are leaving behind
   old database files, so on a next run, in dev environment, tests' setup fails with `database exists` exception.
   
   This fix cleans up old database files prior running the unit tests, making sure we are always running the test from the same blank state.
   
   ## Testing recommendations
   
   - Run test suite, e.g. `make check apps=couch`.
   - Confirm that there are temporary test databases in `$PWD/tmp/data` and /$PWD/tmp/tmp_data` left behind.
   - Run `rebar setup_eunit`. It's going to fail with "One or more files already exist on disk and were not generated", but it'll clean up `tmp` dir nevertheless, so check out same `$PWD/tmp/data` and /$PWD/tmp/tmp_data` to confirm them to be empty.
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services