You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Chris Nauroth (JIRA)" <ji...@apache.org> on 2016/09/30 17:48:20 UTC
[jira] [Updated] (HADOOP-13150) Avoid use of toString() in output
of HDFS ACL shell commands.
[ https://issues.apache.org/jira/browse/HADOOP-13150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Nauroth updated HADOOP-13150:
-----------------------------------
Attachment: HADOOP-13150.001.patch
I'm attaching patch 001. This is similar to what was done for HDFS-9732.
* I have defined {{toStringStable}} methods and updated call sites in the shell and WebHDFS.
* I took the opportunity to update several of the ACL classes from {{Evolving}} to {{Stable}}. The API hasn't changed since initial release, so I'm confident that we can declare it stable.
* {{AclPermissionParam#parseAclSpec}} needed to stop calling {{StringUtils#join}}, because it internally calls {{toString}}. The new logic is an adaptation of the logic of {{StringUtils#join}}.
* I have not added any new tests. The logic is already covered well by existing tests that parse ACL strings back and forth.
> Avoid use of toString() in output of HDFS ACL shell commands.
> -------------------------------------------------------------
>
> Key: HADOOP-13150
> URL: https://issues.apache.org/jira/browse/HADOOP-13150
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-13150.001.patch
>
>
> The HDFS ACL shell commands have at least one usage of the standard Java {{toString}} method to generate shell output ({{AclEntry#toString}}). This issue tracks conversion of that code to use methods other than {{toString}}. The {{toString}} method is useful primarily for debugging. It's preferrable to use a different method to ensure stable output for public interfaces, such as the shell.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org