You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/13 07:42:05 UTC
[GitHub] [pulsar] LeBW opened a new pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
LeBW opened a new pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
add description for the `earliestMsgPublishTimeInBacklog ` in pulsar-admin.
Original PR: [12523](https://github.com/apache/pulsar/pull/12523)
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API: ( no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [x] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263#discussion_r767701305
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -387,6 +391,7 @@ The following is an example of a topic status.
"msgChunkPublished" : false,
"storageSize" : 504,
"backlogSize" : 0,
+ "earliestMsgPublishTimeInBacklog": 0,
Review comment:
```suggestion
"earliestMsgPublishTimeInBacklogs": 0,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263#discussion_r767477241
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -276,6 +278,8 @@ You can check the following statistics of a given non-partitioned topic.
- **chunkedMessageRate**: Chunked message dispatch rate.
- **backlogSize**: Size of backlog for this subscription (in bytes).
+
+ - **earliestMsgPublishTimeInBacklog**: publish time of the earliest message in the backlog for the subscription.
Review comment:
```suggestion
- **earliestMsgPublishTimeInBacklog**: the publish time of the earliest message in the backlog for the subscription.
```
keep consistent
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -276,6 +278,8 @@ You can check the following statistics of a given non-partitioned topic.
- **chunkedMessageRate**: Chunked message dispatch rate.
- **backlogSize**: Size of backlog for this subscription (in bytes).
+
+ - **earliestMsgPublishTimeInBacklog**: publish time of the earliest message in the backlog for the subscription.
Review comment:
```suggestion
- **earliestMsgPublishTimeInBacklog**: the publish time of the earliest message in the backlog for the subscription.
```
keep consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263#discussion_r767695438
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -197,6 +197,8 @@ You can check the following statistics of a given non-partitioned topic.
- **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
+ - **earliestMsgPublishTimeInBacklogs**: The publish time of the earliest message in the backlog.
Review comment:
Yes, I think it's in milliseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263#discussion_r767705230
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -197,6 +197,8 @@ You can check the following statistics of a given non-partitioned topic.
- **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
+ - **earliestMsgPublishTimeInBacklogs**: The publish time of the earliest message in the backlog.
Review comment:
> Yes, I think it's in milliseconds.
Great, It's better if we can add this in the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] LeBW commented on pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
LeBW commented on pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263#issuecomment-992192648
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263#discussion_r767701113
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -276,6 +278,8 @@ You can check the following statistics of a given non-partitioned topic.
- **chunkedMessageRate**: Chunked message dispatch rate.
- **backlogSize**: Size of backlog for this subscription (in bytes).
+
+ - **earliestMsgPublishTimeInBacklog**: the publish time of the earliest message in the backlog for the subscription.
Review comment:
```suggestion
- **earliestMsgPublishTimeInBacklog**: The publish time of the earliest message in the backlog for the subscription.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] LeBW commented on pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
LeBW commented on pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263#issuecomment-992190275
@Anonymitaet Please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #13263: add description for the `earliestMsgPublishTimeInBacklog `
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #13263:
URL: https://github.com/apache/pulsar/pull/13263#discussion_r767689496
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -197,6 +197,8 @@ You can check the following statistics of a given non-partitioned topic.
- **storageSize**: The sum of the ledgers' storage size for this topic. The space used to store the messages for the topic.
+ - **earliestMsgPublishTimeInBacklogs**: The publish time of the earliest message in the backlog.
Review comment:
It's in format of millisecond timestamp?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org