You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/05/07 06:45:45 UTC
[GitHub] [servicecomb-mesher] t-xinlin commented on a change in pull request #116: Add ut to http server module
t-xinlin commented on a change in pull request #116:
URL: https://github.com/apache/servicecomb-mesher/pull/116#discussion_r421274200
##########
File path: proxy/protocol/dubbo/proxy/dubbo_proxy_ouput.go
##########
@@ -207,9 +207,8 @@ func Handle(ctx *dubbo.InvokeContext) error {
inv.Reply = &dubboclient.WrapResponse{nil} //&rest.Response{Resp: &ctx.Response}
var err error
err = SetLocalServiceAddress(inv) //select local service
- if err != nil {
- openlogging.Error(err.Error())
- return err
+ if err == nil {
+ IsProvider = true
Review comment:
後面的commit已經修復
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org