You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Lev Walkin (JIRA)" <ji...@apache.org> on 2010/08/22 06:51:17 UTC

[jira] Created: (THRIFT-860) copy method and reset method

copy method and reset method
----------------------------

                 Key: THRIFT-860
                 URL: https://issues.apache.org/jira/browse/THRIFT-860
             Project: Thrift
          Issue Type: Improvement
          Components: OCaml - Compiler
            Reporter: Lev Walkin
            Assignee: Bryan Duxbury
         Attachments: thrift-trunk-983568.patch

The attached patch provides the class copying and reset-to-default values methods. The applicability and usefulness is obvious: in many cases the shallow object copying provided by Oo.copy is not sufficient, so a deep copy is needed. This patch provides a deep copy method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (THRIFT-860) copy method and reset method

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-860.
--------------------------------

         Assignee: Lev Walkin  (was: Bryan Duxbury)
    Fix Version/s: 0.5
       Resolution: Fixed

I just committed this. Thanks for the patch!

> copy method and reset method
> ----------------------------
>
>                 Key: THRIFT-860
>                 URL: https://issues.apache.org/jira/browse/THRIFT-860
>             Project: Thrift
>          Issue Type: Improvement
>          Components: OCaml - Compiler
>            Reporter: Lev Walkin
>            Assignee: Lev Walkin
>             Fix For: 0.5
>
>         Attachments: thrift-trunk-983568.patch, thrift-trunk-990296.patch
>
>
> The attached patch provides the class copying and reset-to-default values methods. The applicability and usefulness is obvious: in many cases the shallow object copying provided by Oo.copy is not sufficient, so a deep copy is needed. This patch provides a deep copy method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-860) copy method and reset method

Posted by "Lev Walkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lev Walkin updated THRIFT-860:
------------------------------

    Attachment: thrift-trunk-983568.patch

Deep copy and reset methods.

> copy method and reset method
> ----------------------------
>
>                 Key: THRIFT-860
>                 URL: https://issues.apache.org/jira/browse/THRIFT-860
>             Project: Thrift
>          Issue Type: Improvement
>          Components: OCaml - Compiler
>            Reporter: Lev Walkin
>            Assignee: Bryan Duxbury
>         Attachments: thrift-trunk-983568.patch
>
>
> The attached patch provides the class copying and reset-to-default values methods. The applicability and usefulness is obvious: in many cases the shallow object copying provided by Oo.copy is not sufficient, so a deep copy is needed. This patch provides a deep copy method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-860) copy method and reset method

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901529#action_12901529 ] 

Bryan Duxbury commented on THRIFT-860:
--------------------------------------

I'd love for someone familiar with OCaml to give this a review...

> copy method and reset method
> ----------------------------
>
>                 Key: THRIFT-860
>                 URL: https://issues.apache.org/jira/browse/THRIFT-860
>             Project: Thrift
>          Issue Type: Improvement
>          Components: OCaml - Compiler
>            Reporter: Lev Walkin
>            Assignee: Bryan Duxbury
>         Attachments: thrift-trunk-983568.patch
>
>
> The attached patch provides the class copying and reset-to-default values methods. The applicability and usefulness is obvious: in many cases the shallow object copying provided by Oo.copy is not sufficient, so a deep copy is needed. This patch provides a deep copy method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-860) copy method and reset method

Posted by "Lev Walkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lev Walkin updated THRIFT-860:
------------------------------

    Attachment: thrift-trunk-990296.patch

Cleaner patch to trunk version 990296.

> copy method and reset method
> ----------------------------
>
>                 Key: THRIFT-860
>                 URL: https://issues.apache.org/jira/browse/THRIFT-860
>             Project: Thrift
>          Issue Type: Improvement
>          Components: OCaml - Compiler
>            Reporter: Lev Walkin
>            Assignee: Bryan Duxbury
>         Attachments: thrift-trunk-983568.patch, thrift-trunk-990296.patch
>
>
> The attached patch provides the class copying and reset-to-default values methods. The applicability and usefulness is obvious: in many cases the shallow object copying provided by Oo.copy is not sufficient, so a deep copy is needed. This patch provides a deep copy method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.