You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by cdeneux <gi...@git.apache.org> on 2018/03/05 09:12:23 UTC
[GitHub] commons-pool pull request #4: POOL-337: EvictionTimer does not remove cancel...
GitHub user cdeneux opened a pull request:
https://github.com/apache/commons-pool/pull/4
POOL-337: EvictionTimer does not remove cancelled tasks
EvictionTimer does not remove cancelled tasks from the executor, and so a memory leak occurs.
Thanks to Reinald Verheij for the patch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/petalslink/commons-pool POOL-337
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-pool/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit ec8b7769585bcb86a42a53a2d939c271194ebe9d
Author: cdeneux <ch...@...>
Date: 2018-02-28T17:25:06Z
POOL-337: EvictionTimer does not remove cancelled tasks from the executor
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...
Posted by cdeneux <gi...@git.apache.org>.
Github user cdeneux commented on the issue:
https://github.com/apache/commons-pool/pull/4
Hi @garydgregory,
To be able to release our product [Petals ESB](http://petals.ow2.org/), we wish embed this fix. We can use the official released artefact, or our own forked artefact.
To choose between both ways, can you tell me when you plan to merge this PR and when you release ? Have you everything you needed to do it ?
Regards,
Christophe
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-pool/pull/4
[](https://coveralls.io/builds/15805552)
Coverage increased (+0.06%) to 84.784% when pulling **ec8b7769585bcb86a42a53a2d939c271194ebe9d on petalslink:POOL-337** into **30d5db67a2cd0bf3d9a2dd7ffaa7dd247760a9bd on apache:master**.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/4
I should be able to take a look tomorrow or the next day.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-pool/pull/4
Hello @cdeneux !
Thank you for your PR.
Would you mind updating this PR with a unit test? It would be best if the test failed without the changes to the main file.
Thank you,
Gary
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool pull request #4: POOL-337: EvictionTimer does not remove cancel...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf closed the pull request at:
https://github.com/apache/commons-pool/pull/4
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...
Posted by cdeneux <gi...@git.apache.org>.
Github user cdeneux commented on the issue:
https://github.com/apache/commons-pool/pull/4
Hi @garydgregory,
I have just updated the PR with a unit test validating the correct freeing of eviction objects.
Regards,
Christophe
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-pool issue #4: POOL-337: EvictionTimer does not remove cancelled tas...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the issue:
https://github.com/apache/commons-pool/pull/4
Thanks for the PR. I've fixed this in a slightly different way after reviewing the prior changes. The tst case I used largely as-is. Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org