You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Jasha Joachimsthal <j....@onehippo.com> on 2011/11/08 10:41:51 UTC
Re: svn commit: r1199062 - in /incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF:
dispatcher-servlet.xml jsp/ jsp/views/ views/ web.xml
Good thing to make clear it's the folder for jsp as presentation layer, but
why jsp/views and not just jsp?
On 8 November 2011 03:11, <jc...@apache.org> wrote:
> Author: jcian
> Date: Tue Nov 8 02:11:19 2011
> New Revision: 1199062
>
> URL: http://svn.apache.org/viewvc?rev=1199062&view=rev
> Log:
> Shuffling around where the views are located in preparation for adding
> tiles - supports RAVE-343.
>
> Added:
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/
>
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/
> - copied from r1199057,
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/
> Removed:
>
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/
> Modified:
>
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml
>
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml
>
> Modified:
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml
> URL:
> http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml?rev=1199062&r1=1199061&r2=1199062&view=diff
>
> ==============================================================================
> ---
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml
> (original)
> +++
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/dispatcher-servlet.xml
> Tue Nov 8 02:11:19 2011
> @@ -39,7 +39,7 @@
>
> <!-- Resolves view names to protected .jsp resources within the
> /WEB-INF/views directory -->
> <bean
> class="org.springframework.web.servlet.view.InternalResourceViewResolver">
> - <property name="prefix" value="/WEB-INF/views/"/>
> + <property name="prefix" value="/WEB-INF/jsp/views/"/>
> <property name="suffix" value=".jsp"/>
> </bean>
>
>
> Modified:
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml
> URL:
> http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml?rev=1199062&r1=1199061&r2=1199062&view=diff
>
> ==============================================================================
> ---
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml
> (original)
> +++
> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml
> Tue Nov 8 02:11:19 2011
> @@ -74,6 +74,6 @@
>
> <error-page>
> <exception-type>java.lang.Throwable</exception-type>
> - <location>/WEB-INF/views/error.jsp</location>
> + <location>/WEB-INF/jsp/views/error.jsp</location>
> </error-page>
> </web-app>
>
>
>
Re: svn commit: r1199062 - in /incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF:
dispatcher-servlet.xml jsp/ jsp/views/ views/ web.xml
Posted by Jasha Joachimsthal <j....@onehippo.com>.
I get it now :)
what about "components" or is that just as vague as "views"?
On 8 November 2011 16:03, Ciancetta, Jesse E. <jc...@mitre.org> wrote:
> >-----Original Message-----
> >From: Jasha Joachimsthal [mailto:j.joachimsthal@onehippo.com]
> >Sent: Tuesday, November 08, 2011 4:42 AM
> >To: rave-dev@incubator.apache.org
> >Subject: Re: svn commit: r1199062 - in /incubator/rave/trunk/rave-portal-
> >resources/src/main/webapp/WEB-INF: dispatcher-servlet.xml jsp/ jsp/views/
> >views/ web.xml
> >
> >Good thing to make clear it's the folder for jsp as presentation layer,
> but
> >why jsp/views and not just jsp?
>
> I'm planning to add a bunch of other folders under WEB-INF/jsp as well --
> although we still may want to change "views" to something else at some
> point. Some of the other folders I'll be adding will be:
>
> WEB-INF/jsp/common -- place for common stuff like header and footer code
> WEB-INF/jsp/includes -- place for includes like JSP taglib definitions
> WEB-INF/jsp/templates -- place for tiles base layout template files
>
> What will end up left in the current "views" folder will be basically just
> the content that makes up the body of each page (the content between the
> header and footer).
>
> Anyone have and good suggestions for what to change the folder name to if
> we don't stick with "views"? I've used "tiles" in the past since they end
> up being little "tiles" of content but I'm not sure I really like that
> either since it might be confused with tiles proper.
>
> >On 8 November 2011 03:11, <jc...@apache.org> wrote:
> >
> >> Author: jcian
> >> Date: Tue Nov 8 02:11:19 2011
> >> New Revision: 1199062
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1199062&view=rev
> >> Log:
> >> Shuffling around where the views are located in preparation for adding
> >> tiles - supports RAVE-343.
> >>
> >> Added:
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/jsp/
> >>
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/jsp/views/
> >> - copied from r1199057,
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/views/
> >> Removed:
> >>
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/views/
> >> Modified:
> >>
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/dispatcher-servlet.xml
> >>
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/web.xml
> >>
> >> Modified:
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/dispatcher-servlet.xml
> >> URL:
> >> http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal-
> >resources/src/main/webapp/WEB-INF/dispatcher-
> >servlet.xml?rev=1199062&r1=1199061&r2=1199062&view=diff
> >>
> >>
> >===========================================================
> >===================
> >> ---
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/dispatcher-servlet.xml
> >> (original)
> >> +++
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/dispatcher-servlet.xml
> >> Tue Nov 8 02:11:19 2011
> >> @@ -39,7 +39,7 @@
> >>
> >> <!-- Resolves view names to protected .jsp resources within the
> >> /WEB-INF/views directory -->
> >> <bean
> >>
> >class="org.springframework.web.servlet.view.InternalResourceViewResolver
> >">
> >> - <property name="prefix" value="/WEB-INF/views/"/>
> >> + <property name="prefix" value="/WEB-INF/jsp/views/"/>
> >> <property name="suffix" value=".jsp"/>
> >> </bean>
> >>
> >>
> >> Modified:
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/web.xml
> >> URL:
> >> http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal-
> >resources/src/main/webapp/WEB-
> >INF/web.xml?rev=1199062&r1=1199061&r2=1199062&view=diff
> >>
> >>
> >===========================================================
> >===================
> >> ---
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/web.xml
> >> (original)
> >> +++
> >> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
> >INF/web.xml
> >> Tue Nov 8 02:11:19 2011
> >> @@ -74,6 +74,6 @@
> >>
> >> <error-page>
> >> <exception-type>java.lang.Throwable</exception-type>
> >> - <location>/WEB-INF/views/error.jsp</location>
> >> + <location>/WEB-INF/jsp/views/error.jsp</location>
> >> </error-page>
> >> </web-app>
> >>
> >>
> >>
>
RE: svn commit: r1199062 - in
/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF:
dispatcher-servlet.xml jsp/ jsp/views/ views/ web.xml
Posted by "Ciancetta, Jesse E." <jc...@mitre.org>.
>-----Original Message-----
>From: Jasha Joachimsthal [mailto:j.joachimsthal@onehippo.com]
>Sent: Tuesday, November 08, 2011 4:42 AM
>To: rave-dev@incubator.apache.org
>Subject: Re: svn commit: r1199062 - in /incubator/rave/trunk/rave-portal-
>resources/src/main/webapp/WEB-INF: dispatcher-servlet.xml jsp/ jsp/views/
>views/ web.xml
>
>Good thing to make clear it's the folder for jsp as presentation layer, but
>why jsp/views and not just jsp?
I'm planning to add a bunch of other folders under WEB-INF/jsp as well -- although we still may want to change "views" to something else at some point. Some of the other folders I'll be adding will be:
WEB-INF/jsp/common -- place for common stuff like header and footer code
WEB-INF/jsp/includes -- place for includes like JSP taglib definitions
WEB-INF/jsp/templates -- place for tiles base layout template files
What will end up left in the current "views" folder will be basically just the content that makes up the body of each page (the content between the header and footer).
Anyone have and good suggestions for what to change the folder name to if we don't stick with "views"? I've used "tiles" in the past since they end up being little "tiles" of content but I'm not sure I really like that either since it might be confused with tiles proper.
>On 8 November 2011 03:11, <jc...@apache.org> wrote:
>
>> Author: jcian
>> Date: Tue Nov 8 02:11:19 2011
>> New Revision: 1199062
>>
>> URL: http://svn.apache.org/viewvc?rev=1199062&view=rev
>> Log:
>> Shuffling around where the views are located in preparation for adding
>> tiles - supports RAVE-343.
>>
>> Added:
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/jsp/
>>
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/jsp/views/
>> - copied from r1199057,
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/views/
>> Removed:
>>
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/views/
>> Modified:
>>
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/dispatcher-servlet.xml
>>
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/web.xml
>>
>> Modified:
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/dispatcher-servlet.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal-
>resources/src/main/webapp/WEB-INF/dispatcher-
>servlet.xml?rev=1199062&r1=1199061&r2=1199062&view=diff
>>
>>
>===========================================================
>===================
>> ---
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/dispatcher-servlet.xml
>> (original)
>> +++
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/dispatcher-servlet.xml
>> Tue Nov 8 02:11:19 2011
>> @@ -39,7 +39,7 @@
>>
>> <!-- Resolves view names to protected .jsp resources within the
>> /WEB-INF/views directory -->
>> <bean
>>
>class="org.springframework.web.servlet.view.InternalResourceViewResolver
>">
>> - <property name="prefix" value="/WEB-INF/views/"/>
>> + <property name="prefix" value="/WEB-INF/jsp/views/"/>
>> <property name="suffix" value=".jsp"/>
>> </bean>
>>
>>
>> Modified:
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/web.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal-
>resources/src/main/webapp/WEB-
>INF/web.xml?rev=1199062&r1=1199061&r2=1199062&view=diff
>>
>>
>===========================================================
>===================
>> ---
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/web.xml
>> (original)
>> +++
>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-
>INF/web.xml
>> Tue Nov 8 02:11:19 2011
>> @@ -74,6 +74,6 @@
>>
>> <error-page>
>> <exception-type>java.lang.Throwable</exception-type>
>> - <location>/WEB-INF/views/error.jsp</location>
>> + <location>/WEB-INF/jsp/views/error.jsp</location>
>> </error-page>
>> </web-app>
>>
>>
>>