You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Daniel Becker (Jira)" <ji...@apache.org> on 2025/02/25 09:37:00 UTC

[jira] [Created] (IMPALA-13793) Always close expressions

Daniel Becker created IMPALA-13793:
--------------------------------------

             Summary: Always close expressions
                 Key: IMPALA-13793
                 URL: https://issues.apache.org/jira/browse/IMPALA-13793
             Project: IMPALA
          Issue Type: Improvement
          Components: Backend
            Reporter: Daniel Becker
            Assignee: Daniel Becker


The Expr class has a Close() method, which is currently only used for releasing 'cache_entry_', which is used for UDF or UDAF functions. If Close() is not called for an Expr that uses 'cache_entry_', a DCHECK fails in the destructor of Expr.

However, if an Expr does not use 'cache_entry_' is not closed, nothing happens. Classes holding Expr objects should always close expressions because they may use 'cache_entry_'. However, if tests fail to include cases where 'cache_entry_' is used, bugs may not be detected: one such case was [IMPALA-13770|http://issues.apache.org/jira/browse/IMPALA-13770].

We should always enforce closing expressions to make it easier to detect bugs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org