You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Dipu <di...@googlemail.com> on 2008/11/26 15:25:12 UTC
AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1
wicket-autocomplete.js
function function showAutoComplete()
line 291
container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
looks like IE doesn't like big i in zIndex, IE seem to be be happy with
zindex
not sure if that's the correct way to resolve the issue, i have attached a
patch though.
Thanks
Dipu
Re: AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1
Posted by Jeremy Thomerson <je...@wickettraining.com>.
Wow! Thanks! Good to know since I need to release an app today on a
modified version of rc1 just because of this app. I didn't look into it any
more last night after changing to snapshot and seeing it work.
Thanks again,
Jeremy Thomerson
http://www.wickettraining.com
On Wed, Nov 26, 2008 at 10:48 AM, Dipu <di...@googlemail.com> wrote:
> In the current trunk, it's reverted back
> to
> container.style.zIndex=(Number(index)!=Number.NaN?Number(index)+1:index);
> and
> it works,
> but its working because some thing else is broken
>
> when the value of index ='auto';
> the expression (Number(index)!=Number.NaN?Number(index)+1:index); return
> NaN,
> this looks wrong to me it should be returning 'auto'
>
> for example if you run the following line in javascript console in firebug
> you will get NaN
> var index ='auto';(Number(index)!=Number.NaN?Number(index)+1:index)
> if you run Number(index) it return NaN
>
> but Number(index)!=Number.NaN yields true (looks wrong to me)
>
> just my 2 cents
>
> Cheers
> Dipu
>
>
>
>
>
> On Wed, Nov 26, 2008 at 4:29 PM, Jeremy Thomerson <
> jeremy@wickettraining.com
> > wrote:
>
> > This is fixed in trunk - I just ran into the same yesterday. Upgraded
> from
> > rc1 to snapshot and it's working.
> >
> > --
> > Jeremy Thomerson
> > http://www.wickettraining.com
> >
> >
> >
> > On Wed, Nov 26, 2008 at 9:32 AM, Dipu <di...@googlemail.com> wrote:
> >
> > > done <https://issues.apache.org/jira/browse/WICKET-1960>
> > > https://issues.apache.org/jira/browse/WICKET-1960
> > >
> > > On Wed, Nov 26, 2008 at 2:44 PM, James Carman <
> > james@carmanconsulting.com
> > > >wrote:
> > >
> > > > The best way would be to file a JIRA (or search for an existing one
> > that
> > > > explains this issue) and attach your patch there. We're not allowed
> to
> > > > apply patches unless they're submitted through JIRA and they have the
> > > > "Grant
> > > > license to ASF for inclusion in ASF works" thing checked.
> > > >
> > > > On Wed, Nov 26, 2008 at 9:25 AM, Dipu <di...@googlemail.com>
> wrote:
> > > >
> > > > > wicket-autocomplete.js
> > > > > function function showAutoComplete()
> > > > > line 291
> > > > >
> container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
> > > > >
> > > > > looks like IE doesn't like big i in zIndex, IE seem to be be happy
> > with
> > > > > zindex
> > > > >
> > > > > not sure if that's the correct way to resolve the issue, i have
> > > attached
> > > > a
> > > > > patch though.
> > > > >
> > > > >
> > > > > Thanks
> > > > > Dipu
> > > > >
> > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > > >
> > > >
> > >
> >
>
Re: AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1
Posted by Dipu <di...@googlemail.com>.
In the current trunk, it's reverted back
to container.style.zIndex=(Number(index)!=Number.NaN?Number(index)+1:index);
and
it works,
but its working because some thing else is broken
when the value of index ='auto';
the expression (Number(index)!=Number.NaN?Number(index)+1:index); return
NaN,
this looks wrong to me it should be returning 'auto'
for example if you run the following line in javascript console in firebug
you will get NaN
var index ='auto';(Number(index)!=Number.NaN?Number(index)+1:index)
if you run Number(index) it return NaN
but Number(index)!=Number.NaN yields true (looks wrong to me)
just my 2 cents
Cheers
Dipu
On Wed, Nov 26, 2008 at 4:29 PM, Jeremy Thomerson <jeremy@wickettraining.com
> wrote:
> This is fixed in trunk - I just ran into the same yesterday. Upgraded from
> rc1 to snapshot and it's working.
>
> --
> Jeremy Thomerson
> http://www.wickettraining.com
>
>
>
> On Wed, Nov 26, 2008 at 9:32 AM, Dipu <di...@googlemail.com> wrote:
>
> > done <https://issues.apache.org/jira/browse/WICKET-1960>
> > https://issues.apache.org/jira/browse/WICKET-1960
> >
> > On Wed, Nov 26, 2008 at 2:44 PM, James Carman <
> james@carmanconsulting.com
> > >wrote:
> >
> > > The best way would be to file a JIRA (or search for an existing one
> that
> > > explains this issue) and attach your patch there. We're not allowed to
> > > apply patches unless they're submitted through JIRA and they have the
> > > "Grant
> > > license to ASF for inclusion in ASF works" thing checked.
> > >
> > > On Wed, Nov 26, 2008 at 9:25 AM, Dipu <di...@googlemail.com> wrote:
> > >
> > > > wicket-autocomplete.js
> > > > function function showAutoComplete()
> > > > line 291
> > > > container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
> > > >
> > > > looks like IE doesn't like big i in zIndex, IE seem to be be happy
> with
> > > > zindex
> > > >
> > > > not sure if that's the correct way to resolve the issue, i have
> > attached
> > > a
> > > > patch though.
> > > >
> > > >
> > > > Thanks
> > > > Dipu
> > > >
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > > For additional commands, e-mail: users-help@wicket.apache.org
> > > >
> > >
> >
>
Re: AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1
Posted by Jeremy Thomerson <je...@wickettraining.com>.
This is fixed in trunk - I just ran into the same yesterday. Upgraded from
rc1 to snapshot and it's working.
--
Jeremy Thomerson
http://www.wickettraining.com
On Wed, Nov 26, 2008 at 9:32 AM, Dipu <di...@googlemail.com> wrote:
> done <https://issues.apache.org/jira/browse/WICKET-1960>
> https://issues.apache.org/jira/browse/WICKET-1960
>
> On Wed, Nov 26, 2008 at 2:44 PM, James Carman <james@carmanconsulting.com
> >wrote:
>
> > The best way would be to file a JIRA (or search for an existing one that
> > explains this issue) and attach your patch there. We're not allowed to
> > apply patches unless they're submitted through JIRA and they have the
> > "Grant
> > license to ASF for inclusion in ASF works" thing checked.
> >
> > On Wed, Nov 26, 2008 at 9:25 AM, Dipu <di...@googlemail.com> wrote:
> >
> > > wicket-autocomplete.js
> > > function function showAutoComplete()
> > > line 291
> > > container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
> > >
> > > looks like IE doesn't like big i in zIndex, IE seem to be be happy with
> > > zindex
> > >
> > > not sure if that's the correct way to resolve the issue, i have
> attached
> > a
> > > patch though.
> > >
> > >
> > > Thanks
> > > Dipu
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > > For additional commands, e-mail: users-help@wicket.apache.org
> > >
> >
>
Re: AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1
Posted by Dipu <di...@googlemail.com>.
done <https://issues.apache.org/jira/browse/WICKET-1960>
https://issues.apache.org/jira/browse/WICKET-1960
On Wed, Nov 26, 2008 at 2:44 PM, James Carman <ja...@carmanconsulting.com>wrote:
> The best way would be to file a JIRA (or search for an existing one that
> explains this issue) and attach your patch there. We're not allowed to
> apply patches unless they're submitted through JIRA and they have the
> "Grant
> license to ASF for inclusion in ASF works" thing checked.
>
> On Wed, Nov 26, 2008 at 9:25 AM, Dipu <di...@googlemail.com> wrote:
>
> > wicket-autocomplete.js
> > function function showAutoComplete()
> > line 291
> > container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
> >
> > looks like IE doesn't like big i in zIndex, IE seem to be be happy with
> > zindex
> >
> > not sure if that's the correct way to resolve the issue, i have attached
> a
> > patch though.
> >
> >
> > Thanks
> > Dipu
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> > For additional commands, e-mail: users-help@wicket.apache.org
> >
>
Re: AutoCompleteTextField - gives a type mismatch error on IE - version wicket-1.4-rc1
Posted by James Carman <ja...@carmanconsulting.com>.
The best way would be to file a JIRA (or search for an existing one that
explains this issue) and attach your patch there. We're not allowed to
apply patches unless they're submitted through JIRA and they have the "Grant
license to ASF for inclusion in ASF works" thing checked.
On Wed, Nov 26, 2008 at 9:25 AM, Dipu <di...@googlemail.com> wrote:
> wicket-autocomplete.js
> function function showAutoComplete()
> line 291
> container.style.zIndex=(!isNaN(Number(index))?Number(index)+1:index);
>
> looks like IE doesn't like big i in zIndex, IE seem to be be happy with
> zindex
>
> not sure if that's the correct way to resolve the issue, i have attached a
> patch though.
>
>
> Thanks
> Dipu
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>