You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/09/26 12:54:32 UTC
[commons-geometry] 05/07: Fix unit vector test precision
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
commit a0fdcf120947803bfb5d15e403b92da9bfa34be3
Author: Steven Fontaine <si...@gmail.com>
AuthorDate: Wed Sep 25 13:39:50 2019 -0500
Fix unit vector test precision
(Also fixes several nearby instances of spurious whitespace)
---
.../commons/geometry/euclidean/oned/Vector1DTest.java | 8 ++++----
.../commons/geometry/euclidean/threed/Vector3DTest.java | 14 +++++++-------
.../commons/geometry/euclidean/twod/Vector2DTest.java | 6 +++---
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java
index 97a697a..4583d8b 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java
@@ -116,9 +116,9 @@ public class Vector1DTest {
public void testNorm_unitVectors() {
// arrange
Vector1D v = Vector1D.of(2.0).normalize();
-
+
// act/assert
- Assert.assertEquals(1.0, v.norm(), TEST_TOLERANCE);
+ Assert.assertEquals(1.0, v.norm(), 0.0);
}
@Test
@@ -133,9 +133,9 @@ public class Vector1DTest {
public void testNormSq_unitVectors() {
// arrange
Vector1D v = Vector1D.of(2.0).normalize();
-
+
// act/assert
- Assert.assertEquals(1.0, v.normSq(), TEST_TOLERANCE);
+ Assert.assertEquals(1.0, v.normSq(), 0.0);
}
@Test
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
index b8bc4bd..c4b5de3 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
@@ -159,14 +159,14 @@ public class Vector3DTest {
Assert.assertEquals(Math.sqrt(29), Vector3D.of(2, 3, 4).norm(), EPS);
Assert.assertEquals(Math.sqrt(29), Vector3D.of(-2, -3, -4).norm(), EPS);
}
-
+
@Test
public void testNorm_unitVectors() {
// arrange
Vector3D v = Vector3D.of(1.0, 2.0, 3.0).normalize();
-
+
// act/assert
- Assert.assertEquals(1.0, v.norm(), EPS);
+ Assert.assertEquals(1.0, v.norm(), 0.0);
}
@Test
@@ -176,14 +176,14 @@ public class Vector3DTest {
Assert.assertEquals(29, Vector3D.of(2, 3, 4).normSq(), EPS);
Assert.assertEquals(29, Vector3D.of(-2, -3, -4).normSq(), EPS);
}
-
+
@Test
public void testNormSq_unitVectors() {
// arrange
Vector3D v = Vector3D.of(1.0, 2.0, 3.0).normalize();
-
+
// act/assert
- Assert.assertEquals(1.0, v.normSq(), EPS);
+ Assert.assertEquals(1.0, v.normSq(), 0.0);
}
@Test
@@ -336,7 +336,7 @@ public class Vector3DTest {
// arrange
Vector3D v1 = Vector3D.of(1.0, 2.0, 3.0).normalize();
Vector3D v2 = Vector3D.of(-2.0, -4.0, -3.0).normalize();
-
+
// act/assert
checkVector(v1.negate(), -1.0 / Math.sqrt(14.0), -Math.sqrt(2.0 / 7.0), -3.0 / Math.sqrt(14.0));
checkVector(v2.negate(), 2.0 / Math.sqrt(29.0), 4.0 / Math.sqrt(29.0), 3.0 / Math.sqrt(29.0));
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java
index 2e6ec80..d619342 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java
@@ -149,7 +149,7 @@ public class Vector2DTest {
Vector2D v = Vector2D.of(2.0, 3.0).normalize();
// act/assert
- Assert.assertEquals(1.0, v.norm(), EPS);
+ Assert.assertEquals(1.0, v.norm(), 0.0);
}
@Test
@@ -171,7 +171,7 @@ public class Vector2DTest {
Vector2D v = Vector2D.of(2.0, 3.0).normalize();
// act/assert
- Assert.assertEquals(1.0, v.normSq(), EPS);
+ Assert.assertEquals(1.0, v.normSq(), 0.0);
}
@Test
@@ -332,7 +332,7 @@ public class Vector2DTest {
Vector2D v1 = Vector2D.of(1.0, 1.0).normalize();
Vector2D v2 = Vector2D.of(-1.0, -2.0).normalize();
Vector2D v3 = Vector2D.of(2.0, -3.0).normalize();
-
+
// act/assert
checkVector(v1.negate(), -1.0 / Math.sqrt(2.0), -1.0 / Math.sqrt(2.0));
checkVector(v2.negate(), 1.0 / Math.sqrt(5.0), 2.0 / Math.sqrt(5.0));