You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/05/18 08:17:49 UTC

[GitHub] [incubator-pagespeed-ngx] haohetao opened a new issue #1688: with quiche nginx not work

haohetao opened a new issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688


   the quiche
   https://github.com/cloudflare/quiche/tree/master/extras/nginx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] gishanc removed a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
gishanc removed a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738685060


   According to above comments from impactCN i can see the issue is there in nginx 1.19.4 as well. I guess nginx has nothing to do with it. It is QUICHE and pagespeed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] XOS commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
XOS commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-708244816


   > @Lofesa
   > With Pagespeed off, the browser can open using Http3
   > With Pagespeed on, you can only use HTTP2
   
   me ,too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] gishanc commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
gishanc commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738627975


   I get the same issue when compiling pagespeed with quickhe on nginx-1.18.0 latest stable
   Kindly fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] impactCn commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
impactCn commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-729485697


   hi, I also encountered the same problem. When I built nginx with pagespeed + quic, the build was unsuccessful.
   nginx 1.19.4.
   pageSpeed latest-stable
   
   **configuration**
   
   
   ./configure --prefix=/usr/share/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib64/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --http-client-body-temp-path=/var/lib/nginx/tmp/client_body --http-proxy-temp-path=/var/lib/nginx/tmp/proxy --http-fastcgi-temp-path=/var/lib/nginx/tmp/fastcgi --http-uwsgi-temp-path=/var/lib/nginx/tmp/uwsgi --http-scgi-temp-path=/var/lib/nginx/tmp/scgi --pid-path=/run/nginx.pid --lock-path=/run/lock/subsys/nginx --user=nginx --group=nginx --with-file-aio --with-ipv6 --with-http_ssl_module --with-http_v2_module --with-http_realip_module --with-stream_ssl_preread_module --with-http_addition_module --with-http_xslt_module=dynamic --with-http_image_filter_module=dynamic --with-http_sub_module --with-http_dav_module --with-http_flv_module --with-http_mp4_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_random_index_module --with-http_secu
 re_link_module --with-http_degradation_module --with-http_slice_module --with-http_stub_status_module --with-http_perl_module=dynamic --with-http_auth_request_module --with-mail=dynamic --with-mail_ssl_module --with-pcre --with-pcre-jit --with-stream=dynamic --with-stream_ssl_module --with-google_perftools_module --with-debug --with-cc-opt='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic' --with-ld-opt='-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,-E' --add-module=/usr/local/pagespeed-ngx --add-module=/usr/local/ngx_brotli --with-openssl=../quiche/deps/boringssl --with-http_v3_module --with-quiche=../quiche
   
   **error**
   
   /pagespeed-ngx/psol/include/url -I /usr/local/ngx_brotli/deps/brotli/c/include -I src/mail -I src/stream \
   	-o objs/addon/src/ngx_base_fetch.o \
   	/usr/local/pagespeed-ngx/src/ngx_base_fetch.cc
   In file included from ../quiche/deps/boringssl/.openssl/include/openssl/ex_data.h:114,
                    from ../quiche/deps/boringssl/.openssl/include/openssl/bio.h:66,
                    from ../quiche/deps/boringssl/.openssl/include/openssl/ssl.h:147,
                    from src/event/ngx_event_openssl.h:15,
                    from src/core/ngx_core.h:84,
                    from /usr/local/pagespeed-ngx/src/log_message_handler.h:24,
                    from /usr/local/pagespeed-ngx/src/log_message_handler.cc:21:
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h: In function ‘int sk_OPENSSL_STRING_call_cmp_func(stack_cmp_func, const void**, const void**)’:
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:298:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
     298 |     constptrtype a_ptr = (constptrtype)*a;                                     \
         |                                         ^
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’
     422 |   BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type)
         |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’
     428 | DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING)
         | ^~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:299:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
     299 |     constptrtype b_ptr = (constptrtype)*b;                                     \
         |                                         ^
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’
     422 |   BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type)
         |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’
     428 | DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING)
         | ^~~~~~~~~~~~~~~~~~~~~~~
   cc1plus: all warnings being treated as errors
   make[1]: *** [objs/addon/src/log_message_handler.o] Error 1
   make[1]: *** Waiting for unfinished jobs....
   In file included from ../quiche/deps/boringssl/.openssl/include/openssl/ex_data.h:114,
                    from ../quiche/deps/boringssl/.openssl/include/openssl/bio.h:66,
                    from ../quiche/deps/boringssl/.openssl/include/openssl/ssl.h:147,
                    from src/event/ngx_event_openssl.h:15,
                    from src/core/ngx_core.h:84,
                    from src/http/ngx_http.h:13,
                    from /usr/local/pagespeed-ngx/src/ngx_pagespeed.h:33,
                    from /usr/local/pagespeed-ngx/src/ngx_base_fetch.cc:19:
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h: In function ‘int sk_OPENSSL_STRING_call_cmp_func(stack_cmp_func, const void**, const void**)’:
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:298:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
     298 |     constptrtype a_ptr = (constptrtype)*a;                                     \
         |                                         ^
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’
     422 |   BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type)
         |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’
     428 | DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING)
         | ^~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:299:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
     299 |     constptrtype b_ptr = (constptrtype)*b;                                     \
         |                                         ^
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’
     422 |   BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type)
         |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’
     428 | DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING)
         | ^~~~~~~~~~~~~~~~~~~~~~~
   cc1plus: all warnings being treated as errors
   make[1]: *** [objs/addon/src/ngx_base_fetch.o] Error 1
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738695049


   Can some one try to build pagespeed with boring ssl w/o quiche?
   I think pagespeed spects openssl libraries, not boring ssl. If this is the case, this don´t work until openssl add http3 support.
   
   P.S: I have found this, maybe it help: https://community.clearlinux.org/t/nginx-quic-http3-and-pagespeed-from-sources-howto/5023 and https://community.centminmod.com/threads/centmin-mod-nginx-with-cloudflare-http-3-nginx-patch.18482/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] mwangaben edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
mwangaben edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-654866303


   Hi there, i am having the same issue as  building nginx without quiche  HTTP/3 no problem with speedpage, but this errors pop up when the speedpage and HTTP/3 with quiche ngnix 
   
   In file included from ../quiche/deps/boringssl/.openssl/include/openssl/ex_data.h:114,
                    from ../quiche/deps/boringssl/.openssl/include/openssl/bio.h:66,
                    from ../quiche/deps/boringssl/.openssl/include/openssl/ssl.h:147,
                    from src/event/ngx_event_openssl.h:15,
                    from src/core/ngx_core.h:84,
                    from /home/debian/modules/incubator-pagespeed-ngx-1.13.35.2-stable/src/log_message_handler.h:24,
                    from /home/debian/modules/incubator-pagespeed-ngx-1.13.35.2-stable/src/log_message_handler.cc:21:
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h: In function ‘int sk_OPENSSL_STRING_call_cmp_func(stack_cmp_func, const void**, const void**)’:
   
   `../quiche/deps/boringssl/.openssl/include/openssl/stack.h: In function ‘int sk_OPENSSL_STRING_call_cmp_func(stack_cmp_func, const void**, const void**)’:
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:298:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
        constptrtype a_ptr = (constptrtype)*a;                                     \
                                            ^
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’
      BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’
    DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING)
    ^~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:299:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
        constptrtype b_ptr = (constptrtype)*b;                                     \
                                            ^
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’
      BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’
    DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING)
    ^~~~~~~~~~~~~~~~~~~~~~~
   cc1plus: all warnings being treated as errors
   make[1]: *** [objs/Makefile:1425: objs/addon/src/log_message_handler.o] Error 1
   make[1]: Leaving directory '/home/debian/nginx-1.19.0'
   make: *** [Makefile:8: build] Error 2`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-659983367


   @haohetao the errors are reported by @mwangaben.
   @haohetao you have no buld error but the server don´t work? or what happens?
   What do you have in log files, what about error messages in pagespeed log....  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-657012727


   If you build nginx + quiche w/o pagespeed you get errors?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] jmarantz commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
jmarantz commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-660700904


   No known issues, but it wouldn't surprise me to learn there were incompatibilities between the nginx plugins for pagespeed and quic. I don't have any further details though.
   
   I think I saw something earlier in this thread about boringssl vs openssl and that sounds like it might be an issue. I think it would take someone really wanting to dig in and sort out what the incompatibility is.
   
   IIUC the main symptom is that the browser/server negotiation to establish a Quic connection simply doesn't occur when PageSpeed is enabled. Does anyone know if the nginx plugin for Quic offers some debug logging that might provide more detail?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] haohetao commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
haohetao commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-660049262


   @Lofesa 
   no pagespeed log produce,but http3 not working.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] haohetao commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
haohetao commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-717648885


   > 
   > 
   > Hi there, i am having the same issue as building nginx without quiche HTTP/3 no problem with speedpage, but this errors pop up when the speedpage and HTTP/3 with quiche ngnix
   > 
   > USING THIS CONFIGURATION
   > 
   > ./configure --sbin-path=/usr/sbin/nginx --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --user=www-data --group=www-data --with-pcre --pid-path=/var/run/ngnix.pid --build="quiche-$(git --git-dir=../quiche/.git rev-parse --short HEAD)" --with-http_v2_module --with-http_v3_module --with-openssl=../quiche/deps/boringssl --with-quiche=../quiche --with-http_ssl_module --add-module=/home/debian/modules/ngx_aws_auth-2.1.1 --add-module=/home/debian/modules/incubator-pagespeed-ngx-1.13.35.2-stable
   > 
   > In file included from ../quiche/deps/boringssl/.openssl/include/openssl/ex_data.h:114,
   > from ../quiche/deps/boringssl/.openssl/include/openssl/bio.h:66,
   > from ../quiche/deps/boringssl/.openssl/include/openssl/ssl.h:147,
   > from src/event/ngx_event_openssl.h:15,
   > from src/core/ngx_core.h:84,
   > from /home/debian/modules/incubator-pagespeed-ngx-1.13.35.2-stable/src/log_message_handler.h:24,
   > from /home/debian/modules/incubator-pagespeed-ngx-1.13.35.2-stable/src/log_message_handler.cc:21:
   > ../quiche/deps/boringssl/.openssl/include/openssl/stack.h: In function ‘int sk_OPENSSL_STRING_call_cmp_func(stack_cmp_func, const void**, const void**)’:
   > 
   > `../quiche/deps/boringssl/.openssl/include/openssl/stack.h: In function ‘int sk_OPENSSL_STRING_call_cmp_func(stack_cmp_func, const void**, const void**)’: ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:298:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers] constptrtype a_ptr = (constptrtype)*a; \ ^ ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’ BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’ DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING) ^~~~~~~~~~~~~~~~~~~~~~~ ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:299:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers] constptrtype b_ptr = (constptrtype)*b; \ ^ ../quiche/deps/boringssl/.openssl/include/openssl/sta
 ck.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’ BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’ DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING) ^~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors make[1]: *** [objs/Makefile:1425: objs/addon/src/log_message_handler.o] Error 1 make[1]: Leaving directory '/home/debian/nginx-1.19.0' make: *** [Makefile:8: build] Error 2`
   
   I made the same mistake with ubuntu20.04, but I got it right with 18.04


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] haohetao commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
haohetao commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-660325509


   @Lofesa 
   With Pagespeed off, the browser can open using Http3
   With Pagespeed on, you can only use HTTP2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-660862774


   @jmarantz Maybe the issue is with headers?. As far as I know quiche (the Cloudflare patch for quic over nginx 1.16) or even the official nginx version (https://hg.nginx.org/nginx-quic/file/tip/README) needs a header advertising the quic protocol and port.
   Some like:
   `add_header Alt-Svc '$http3=":443"; ma=86400';`
   And , if I remember, IPRO deletes all headers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] jmarantz commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
jmarantz commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-630795550


   I don't think underlying protocol matters that much to PageSpeed, other
   than a few http2-related optimizations that have been attempted in the past.
   
   Could you say more about what's going wrong?
   
   On Tue, May 19, 2020 at 6:09 AM Lofesa <no...@github.com> wrote:
   
   > I´m not sure, but maybe pagespeed don´t work in any other protocol rather
   > than http.
   > Maybe @oschaaf <https://github.com/oschaaf> or @jmarantz
   > <https://github.com/jmarantz> can say some thing about this
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-630723113>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAO2IPPKLWZKJRATQSCDF23RSJLEHANCNFSM4ND3HERA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] haohetao commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
haohetao commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-658549661


   @Lofesa 
   Yes,I fixed this problem by disabling Pagespeed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] mwangaben edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
mwangaben edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-654866303






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] gishanc edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
gishanc edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738685275


   > > I get the same issue when compiling pagespeed with quiche on nginx-1.18.0 latest stable
   > > Kindly fix.
   > 
   > Are there plans to update on version 1.19.x?
   
   According to above comments i can see the issue is there in nginx 1.19.4 as well. I guess nginx has nothing to do with it. It is QUICHE and pagespeed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] haohetao commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
haohetao commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-659884748


   I no any build erros,this is my dockerfile command
   ```shell
   FROM ubuntu:18.04
   RUN set -x \
           && apt-get install --no-install-recommends -y \
           build-essential software-properties-common flex bison \
           libpcre3-dev libpcre++-dev libxml2 libxml2-dev \
           #liblua5.3 liblua5.3-dev luajit libluajit-5.1-dev \
           libcurl4 doxygen libyajl2 libyajl-dev geoip-bin libgeoip1 libgeoip-dev libtool dh-autoreconf libcurl4-openssl-dev \
           zlib1g-dev unzip git wget unzip language-pack-zh-hans libhiredis-dev libhiredis0.13 libuuid1 uuid-dev \
           cmake golang-go libunwind-dev rustc cargo \
           && ./configure \
           #--add-module=../ModSecurity-nginx \
           --add-module=../ngx_brotli \
           --add-module=../ngx_dynamic_limit_req_module \
           --add-module=../ngx_http_proxy_connect_module \
           --add-module=../headers-more-nginx-module \
           --add-module=../incubator-pagespeed-ngx-${NGINX_PAGESPEED_VERSION}-${NGINX_PAGESPEED_RELEASE_STATUS} \
           --build="quiche-$(git --git-dir=../quiche/.git rev-parse --short HEAD)" \
           --with-http_v3_module \
           --with-quiche=../quiche \
           --with-openssl=../quiche/deps/boringssl \
   #       --with-openssl-opt='enable-tls1_3 enable-weak-ssl-ciphers' \
           --with-http_v2_module \
           --with-http_ssl_module \
           --with-http_gzip_static_module \
           --with-stream_geoip_module \
           --without-http_uwsgi_module \
           --without-http_scgi_module \
           --without-http_grpc_module \
           --with-http_realip_module \
           --with-http_geoip_module \
           --with-http_dav_module \
           --with-file-aio \
           --with-threads \
           --with-http_geoip_module \
           --with-pcre-jit \
           --with-cc-opt='-fstack-protector-strong -DTCP_FASTOPEN=23' \
           && make \
           && make install \
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-660066609


   No buld error and no related errors in logs ... Maybe the browser is not quic capable?
   try to test your site in some http/3 test like https://gf.dev/http3-test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] haohetao edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
haohetao edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-659884748


   I no have any build erros,this is my dockerfile command
   ```shell
   FROM ubuntu:18.04
   RUN set -x \
           && apt-get install --no-install-recommends -y \
           build-essential software-properties-common flex bison \
           libpcre3-dev libpcre++-dev libxml2 libxml2-dev \
           #liblua5.3 liblua5.3-dev luajit libluajit-5.1-dev \
           libcurl4 doxygen libyajl2 libyajl-dev geoip-bin libgeoip1 libgeoip-dev libtool dh-autoreconf libcurl4-openssl-dev \
           zlib1g-dev unzip git wget unzip language-pack-zh-hans libhiredis-dev libhiredis0.13 libuuid1 uuid-dev \
           cmake golang-go libunwind-dev rustc cargo \
           && ./configure \
           #--add-module=../ModSecurity-nginx \
           --add-module=../ngx_brotli \
           --add-module=../ngx_dynamic_limit_req_module \
           --add-module=../ngx_http_proxy_connect_module \
           --add-module=../headers-more-nginx-module \
           --add-module=../incubator-pagespeed-ngx-${NGINX_PAGESPEED_VERSION}-${NGINX_PAGESPEED_RELEASE_STATUS} \
           --build="quiche-$(git --git-dir=../quiche/.git rev-parse --short HEAD)" \
           --with-http_v3_module \
           --with-quiche=../quiche \
           --with-openssl=../quiche/deps/boringssl \
   #       --with-openssl-opt='enable-tls1_3 enable-weak-ssl-ciphers' \
           --with-http_v2_module \
           --with-http_ssl_module \
           --with-http_gzip_static_module \
           --with-stream_geoip_module \
           --without-http_uwsgi_module \
           --without-http_scgi_module \
           --without-http_grpc_module \
           --with-http_realip_module \
           --with-http_geoip_module \
           --with-http_dav_module \
           --with-file-aio \
           --with-threads \
           --with-http_geoip_module \
           --with-pcre-jit \
           --with-cc-opt='-fstack-protector-strong -DTCP_FASTOPEN=23' \
           && make \
           && make install \
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] mwangaben commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
mwangaben commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-654866303


   Hi there, i am having the same issue as  building nginx without quiche  HTTP/3 no problem with speedpage, but this errors pop up when the speedpage and HTTP/3 with quiche ngnix 
   
   `../quiche/deps/boringssl/.openssl/include/openssl/stack.h: In function ‘int sk_OPENSSL_STRING_call_cmp_func(stack_cmp_func, const void**, const void**)’:
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:298:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
        constptrtype a_ptr = (constptrtype)*a;                                     \
                                            ^
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’
      BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’
    DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING)
    ^~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:299:41: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
        constptrtype b_ptr = (constptrtype)*b;                                     \
                                            ^
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:422:3: note: in expansion of macro ‘BORINGSSL_DEFINE_STACK_OF_IMPL’
      BORINGSSL_DEFINE_STACK_OF_IMPL(type, type, const type)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../quiche/deps/boringssl/.openssl/include/openssl/stack.h:428:1: note: in expansion of macro ‘DEFINE_SPECIAL_STACK_OF’
    DEFINE_SPECIAL_STACK_OF(OPENSSL_STRING)
    ^~~~~~~~~~~~~~~~~~~~~~~
   cc1plus: all warnings being treated as errors
   make[1]: *** [objs/Makefile:1425: objs/addon/src/log_message_handler.o] Error 1
   make[1]: Leaving directory '/home/debian/nginx-1.19.0'
   make: *** [Makefile:8: build] Error 2`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] gishanc edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
gishanc edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738627975


   I get the same issue when compiling pagespeed with quiche on nginx-1.18.0 latest stable
   Kindly fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] gishanc commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
gishanc commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738685060


   According to above comments from impactCN i can see the issue is there in nginx 1.19.4 as well. I guess nginx has nothing to do with it. It is QUICHE and pagespeed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] XOS removed a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
XOS removed a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-708244816


   > @Lofesa
   > With Pagespeed off, the browser can open using Http3
   > With Pagespeed on, you can only use HTTP2
   
   me ,too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] impactCn commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
impactCn commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738642968


   
   
   
   
   > I get the same issue when compiling pagespeed with quiche on nginx-1.18.0 latest stable
   > Kindly fix.
   
   Are there plans to update on version 1.19.x?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-630723113


   I´m not sure, but maybe pagespeed don´t work in any other protocol rather than http.
   Maybe @oschaaf or @jmarantz can say some thing about this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-658776840


   So if you build nginx+quiche only you have no error, but when build nginx+quiche+pagespeed you get these errors, rigth?
   From the messages you have posted, the problem is in boringssl. I never used boringssl, only openssl and had no clue what happens here. Maybe a newer version of boringssl? I have read the docker build had problems with openssl 1.1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738695049


   Can some one try to build pagespeed with boring ssl w/o quiche?
   I think pagespeed spects openssl libraries, not boring ssl. If this is the case, this don´t work until openssl add http3 support.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] ReyKoxha edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
ReyKoxha edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-916436792


   None of the provided links answers the question.
   However, I just compiled NGINX-QUIC with PageSpeed and Brotli.
   
   Check out the file below.
   [NGINX_QUIC.txt](https://github.com/apache/incubator-pagespeed-ngx/files/7139765/NGINX_QUIC.txt)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-658776840


   So if you build nginx+quiche only you have no error, but when build nginx+quiche+pagespeed you get these errors, rigth?
   From the messages you have posted, the problem is in boringssl. I never used boringssl, only openssl and had no clue what happens here. Maybe a newer version of biringssl? I have read the docker build had problems with openssl 1.1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] jmarantz commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
jmarantz commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-661003917


   PageSpeed, AFAIK, would not touch such a header. It leaves alone all headers it doesn't have specific handling for.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] gishanc commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
gishanc commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-738685275


   > > I get the same issue when compiling pagespeed with quiche on nginx-1.18.0 latest stable
   > > Kindly fix.
   > 
   > Are there plans to update on version 1.19.x?
   
   According to above comments from impactCN i can see the issue is there in nginx 1.19.4 as well. I guess nginx has nothing to do with it. It is QUICHE and pagespeed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] ReyKoxha commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
ReyKoxha commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-916436792


   None of the provided links answers the question.
   However, I just compiled NGINX-QUIC with PageSpeed and Brotli.
   
   `
   # Needed only once
   apt-get install build-essential zlib1g-dev libpcre3 libpcre3-dev libssl-dev libxslt1-dev libgd-dev libgeoip-dev uuid-dev git cmake ninja-build golang libunwind-dev
   
   # Google PageSpeed
   NPS_VERSION=1.14.33.1-RC1
   cd
   wget https://github.com/apache/incubator-pagespeed-ngx/archive/v${NPS_VERSION}.zip
   unzip v${NPS_VERSION}.zip
   nps_dir=$(find . -name "*pagespeed-ngx-${NPS_VERSION}" -type d)
   cd "$nps_dir"
   NPS_RELEASE_NUMBER=${NPS_VERSION/beta/}
   NPS_RELEASE_NUMBER=${NPS_VERSION/stable/}
   psol_url=https://dl.google.com/dl/page-speed/psol/${NPS_RELEASE_NUMBER}.tar.gz
   [ -e scripts/format_binary_url.sh ] && psol_url=$(scripts/format_binary_url.sh PSOL_BINARY_URL)
   wget ${psol_url}
   tar -xzvf $(basename ${psol_url})  # extracts to psol/
   
   # BoringSSL
   cd
   git clone https://boringssl.googlesource.com/boringssl boringssl
   cd boringssl
   mkdir build
   cd build
   cmake -DCMAKE_BUILD_TYPE=Release -GNinja ../
   ninja
   
   # Brotli
   cd
   git clone https://github.com/google/ngx_brotli.git ngx_brotli
   
   # NGINX Quic Branch
   cd
   hg clone -b quic https://hg.nginx.org/nginx-quic
   cd /root/ngx_brotli && git submodule update --init && cd /root/nginx-quic
   cd nginx-quic
   CFLAGS="-Wno-ignored-qualifiers" ./auto/configure --prefix=/usr/local/nginx \
   --sbin-path=/usr/sbin/nginx \
   --add-module=$HOME/$nps_dir ${PS_NGX_EXTRA_FLAGS} \
   --add-module=/root/ngx_brotli \
   --conf-path=/etc/nginx/nginx.conf \
   --error-log-path=/var/log/nginx/error.log \
   --http-log-path=/var/log/nginx/access.log \
   --pid-path=/var/run/nginx.pid \
   --lock-path=/var/run/lock/subsys/nginx \
   --with-stream \
   --with-threads \
   --with-file-aio \
   --with-stream_ssl_preread_module \
   --with-http_secure_link_module \
   --with-http_ssl_module \
   --with-http_v2_module \
   --with-http_v3_module \
   --with-http_quic_module \
   --with-stream_quic_module \
   --with-cc-opt="-I/root/boringssl/include $(CFLAGS)"   \
   --with-ld-opt="-L/root/boringssl/build/ssl  \
   -L/root/boringssl/build/crypto $(LDFLAGS)" \
   --with-http_stub_status_module \
   --with-http_gzip_static_module \
   --without-mail_pop3_module \
   --without-mail_imap_module \
   --without-mail_smtp_module
   make
   make install
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] haohetao edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
haohetao edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-658549661


   @Lofesa 
   No Errors,I build pagespeed and quiche both,and set pagespeed to off.
   I'm using dockerfile build


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa edited a comment on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa edited a comment on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-660066609


   @haohetao
   No build error and no related errors in logs ... Maybe the browser is not quic capable?
   try to test your site in some http/3 test like https://gf.dev/http3-test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] Lofesa commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
Lofesa commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-660685803


   So I return to one of my past [post](https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-630723113) maybe pagespeed only work with TCP not by UDP.
   @oschaaf @jmarantz any clue here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-pagespeed-ngx] haohetao commented on issue #1688: with quiche nginx not work

Posted by GitBox <gi...@apache.org>.
haohetao commented on issue #1688:
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1688#issuecomment-660050295


   There are some logs, but not related to quiche
   ```
   2020/07/17 18:57:39 [error] 9#22: [ngx_pagespeed 1.13.35.2-0] Failed to make directory /var/cache/ngx_pagespeed/v3/youtuoapp.com/https,3A/,2Fadmin.award.youtuoapp.com/assets/606d84b4/js: File exists
   2020/07/17 18:57:39 [error] 9#22: [ngx_pagespeed 1.13.35.2-0] Could not create directories for file /var/cache/ngx_pagespeed/v3/youtuoapp.com/https,3A/,2Fadmin.award.youtuoapp.com/assets/606d84b4/js/bootstrap.js,.temp
   2020/07/17 18:57:39 [error] 6#6: *65 FastCGI sent in stderr: "PHP message: PHP Notice:  Trying to get property 'name' of non-object in /var/www/epmms2-award/backend/views/layouts/header.php on line 234PHP message: PHP Notice:  Trying to get property 'admin_jobtitle' of non-object in /var/www/epmms2-award/backend/views/layouts/header.php on line 242PHP message: PHP Notice:  Trying to get property 'admin_add_datetime' of non-object in /var/www/epmms2-award/backend/views/layouts/header.php on line 243PHP message: PHP Notice:  Trying to get property 'name' of non-object in /var/www/epmms2-award/backend/views/layouts/left.php on line 12" while reading response header from upstream, client: 192.168.31.3, server: admin.award.youtuoapp.com, request: "GET /bootstrap.css.map HTTP/2.0", upstream: "fastcgi://192.168.10.10:9000", host: "admin.award.youtuoapp.com"
   2020/07/17 18:58:19 [error] 6#6: *104 open() "/var/www/epmms2-award/images/common/product/5ed06d824beb7.jpg" failed (2: No such file or directory), client: 192.168.31.82, server: img.award.youtuoapp.com, request: "GET /product/5ed06d824beb7.jpg HTTP/2.0", host: "img.award.youtuoapp.com", referrer: "http://localhost:8080/"
   2020/07/17 18:58:19 [error] 6#6: *104 open() "/var/www/epmms2-award/images/common/product/5ecdc53aba0be.jpg" failed (2: No such file or directory), client: 192.168.31.82, server: img.award.youtuoapp.com, request: "GET /product/5ecdc53aba0be.jpg HTTP/2.0", host: "img.award.youtuoapp.com", referrer: "http://localhost:8080/"
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org