You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Will Glass-Husain (JIRA)" <ji...@apache.org> on 2005/09/19 07:18:54 UTC

[jira] Commented: (VELOCITY-222) [patch] add javacc task to build.xml

    [ http://issues.apache.org/jira/browse/VELOCITY-222?page=comments#action_12329767 ] 

Will Glass-Husain commented on VELOCITY-222:
--------------------------------------------

Ant 1.6 has been out for almost 2 years now.  (Since December of 2003).  I'm wondering if anyone objects if we put this patch in.

Note that there's no loss of functionality for earlier versions of ant - the taks should simply display a warning message if the ant dependency isn't met.

> [patch] add javacc task to build.xml
> ------------------------------------
>
>          Key: VELOCITY-222
>          URL: http://issues.apache.org/jira/browse/VELOCITY-222
>      Project: Velocity
>         Type: Improvement
>   Components: Build
>     Versions: 1.5
>  Environment: Operating System: other
> Platform: Other
>     Reporter: Will Glass-Husain
>     Assignee: Velocity-Dev List
>     Priority: Minor
>      Fix For: 1.5
>  Attachments: build.xml.patch, build.xml.patch, build.xml.patch, build.xml.patch
>
> This patch adds a new task "parser" to build.xml.  This task runs jjtree and 
> javacc on the source file Parser.jjt.  It's an independent task, nothing else 
> is dependent on it.  (such as compile).  The purpose is to speed up 
> integrating changes to the parse syntax into the source tree.  (replacing the 
> odd and non-platform independent "build" script at 
> src/org/apache/velocity/runtime/parser).
> Including this patch as an optional task would make things more efficient for 
> those of us playing with the syntax, but keep compilation simple in general.
> You could argue that this task should be integrated into the general build 
> process (e.g. remove Parser.java, etc. out of the source tree), but I think 
> this wouldn't be wise.  The main reason is that it makes it too hard for 
> novice developers to compile Velocity.  (They'd have to learn javacc in 
> addition to ant).  It'd be good to keep the barriers to entry for developers 
> low.  
> Finally, note that ant 1.5 is not compatible with javacc 3.x.  To use this 
> task with javacc3.1, you must upgrade to the 1.6 version of ant (currently 
> only available as a nightly build).  I've found it useful, but some may feel 
> this is enough of a reason to keep this patch out of CVS.  (I'd appreciate 
> comments).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org