[GitHub] [hbase] mattf-apache edited a comment on pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

[GitBox <gi...@apache.org>]

mattf-apache edited a comment on pull request #1620:
URL: https://github.com/apache/hbase/pull/1620#issuecomment-643814757


   > If you've set up your gpg agent and unlocked your private key for it then you do not need to give the passphrase during the build. the README goes over increasing the timeout to a day instead of 2 hours.
   
   Nice, I missed that on my earlier read-thru.  Thanks.
   
   > yes your gpg agent has to be running on your local machine before hand. ...
   > I could add an example of forcing a clean start of the gpg-agent, e.g. gpgconf --kill all && gpg-connect-agent /bye
   > The test signature at container launch should ensure the key is unlocked prior to us building artifacts.
   
   I recommend adding that example in the README.  I think most people do not have gpg-agent running by default, may not know how to launch it (I was vague on it), and while it is true that the test signature at container launch will catch a missing agent timely, it won't tell the user how to fix the problem. -- So, maybe also have that test sig command catch failure and give an instructive error message. Please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org