You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/24 17:38:29 UTC

[GitHub] [incubator-nuttx] davids5 commented on pull request #3169: arch/stm32h7 - Fix compiler warnings and error in stm32_dma.c

davids5 commented on pull request #3169:
URL: https://github.com/apache/incubator-nuttx/pull/3169#issuecomment-806025894


   @hartmannathan  
   
   I have seen a lot of fixes for this class of error using different approaches. @patacongo mentioned the conical form as you have used here in. I was trying to discern the correct pattern and if it is divided on a common OS and arch driver  boundary.  Are are just not being consistent and should ask for changes on PRs. 
   
   To that end, do you feel we should add an explicit `#include <inttypes.h>` to these files?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org