You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2012/07/18 11:07:39 UTC

git commit: fix possible javascript null pointer access (as experienced on IE8)

Updated Branches:
  refs/heads/master f1bad0fc8 -> af1cf1b29


fix possible javascript null pointer access (as experienced on IE8)


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/af1cf1b2
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/af1cf1b2
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/af1cf1b2

Branch: refs/heads/master
Commit: af1cf1b29737739e47d03099a1a1b609779a081c
Parents: f1bad0f
Author: Peter Ertl <pe...@apache.org>
Authored: Wed Jul 18 10:54:17 2012 +0200
Committer: Peter Ertl <pe...@apache.org>
Committed: Wed Jul 18 10:54:17 2012 +0200

----------------------------------------------------------------------
 .../wicket/markup/html/form/CheckGroupSelector.js  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/af1cf1b2/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroupSelector.js
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroupSelector.js b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroupSelector.js
index 44ae16c..21207fe 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroupSelector.js
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/CheckGroupSelector.js
@@ -34,7 +34,7 @@ if (typeof (Wicket.CheckboxSelector.Group) === "undefined") {
 			var result = [];
 			var parentForm = Wicket.$(formId);
 			var parentGroup = parentForm[groupName];
-			if (parentGroup.length) {
+			if (parentGroup && parentGroup.length) {
 				for ( var i = 0; i < parentGroup.length; i++) {
 					var checkbox = parentGroup[i];
 					result.push(checkbox);