You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/12/04 06:36:52 UTC

[GitHub] [trafficserver] masaori335 commented on a change in pull request #6241: Make Allocator.h less silly (no creepy "proto" object).

masaori335 commented on a change in pull request #6241:
URL: https://github.com/apache/trafficserver/pull/6241#discussion_r535869238



##########
File path: include/tscore/Allocator.h
##########
@@ -142,6 +140,9 @@ template <class C> class ClassAllocator : public Allocator
   void
   free(C *ptr)
   {
+    if (Destruct_on_free) {

Review comment:
       Seems a nice idea. I always struggle with how to destroy/free objects when I use `ClassAllocator`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org