You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/26 13:44:01 UTC

[GitHub] [spark] tanelk commented on pull request #30134: [SPARK-33225][SQL] Extract AliasHelper trait

tanelk commented on pull request #30134:
URL: https://github.com/apache/spark/pull/30134#issuecomment-716554760


   > Have you checked all the place where `Alias`s are used in analyzer/optimizer?
   
   There were some places, but I did not feel that they deserved to get a method extracted. For example:
   https://github.com/tanelk/spark/blob/63abab41b40e98947a5cb340a966e657e6b03632/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L3741


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org