You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "David Blevins (JIRA)" <ji...@apache.org> on 2012/04/25 14:42:43 UTC
[jira] [Created] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default. Only needed for Geronimo
David Blevins created TOMEE-167:
-----------------------------------
Summary: Disable support for legacy v2 openejb-jar.xml by default. Only needed for Geronimo
Key: TOMEE-167
URL: https://issues.apache.org/jira/browse/TOMEE-167
Project: TomEE
Issue Type: Improvement
Reporter: David Blevins
Assignee: David Blevins
Fix For: 1.0.0
Only needed for Geronimo, not needed for TomEE.
Loading the quite large JAXB tree takes a few hundred milliseconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default. Only needed for Geronimo
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1
if it is not in the v3 DD it should be
- Romain
2012/4/25 Jean-Louis MONTEIRO <je...@gmail.com>
> here it is ...
> Failure: http://ci.apache.org/builders/openejb-trunk-ubuntu/builds/2234
>
> JLouis
>
> Le 25 avril 2012 15:21, Jean-Louis MONTEIRO <je...@gmail.com> a écrit :
>
> > This file is useful for JAX-WS et WSS integration.
> > Some examples (and therefor the build I guess) won't work anymore.
> >
> > Jean-Louis
> >
> >
> > Le 25 avril 2012 15:12, Mark Struberg <st...@yahoo.de> a écrit :
> >
> > In general I'm +1 for the change.
> >>
> >> Is there any configuration in TomEE where we could enable the old
> >> behaviour with if someone needs it?
> >>
> >> LieGrue,
> >> strub
> >>
> >>
> >>
> >> ----- Original Message -----
> >> > From: Jean-Louis MONTEIRO <je...@gmail.com>
> >> > To: dev@openejb.apache.org
> >> > Cc:
> >> > Sent: Wednesday, April 25, 2012 2:45 PM
> >> > Subject: Re: [jira] [Created] (TOMEE-167) Disable support for legacy
> v2
> >> openejb-jar.xml by default. Only needed for Geronimo
> >> >
> >> > Don't agree David.
> >> >
> >> > Saving hundred milliseconds also disabled very interesting features.
> >> >
> >> > JLouis
> >> >
> >> >
> >> > Le 25 avril 2012 14:42, David Blevins (JIRA) <ji...@apache.org> a
> écrit
> >> :
> >> >
> >> >> David Blevins created TOMEE-167:
> >> >> -----------------------------------
> >> >>
> >> >> Summary: Disable support for legacy v2 openejb-jar.xml
> by
> >> >> default. Only needed for Geronimo
> >> >> Key: TOMEE-167
> >> >> URL:
> https://issues.apache.org/jira/browse/TOMEE-167
> >> >> Project: TomEE
> >> >> Issue Type: Improvement
> >> >> Reporter: David Blevins
> >> >> Assignee: David Blevins
> >> >> Fix For: 1.0.0
> >> >>
> >> >>
> >> >> Only needed for Geronimo, not needed for TomEE.
> >> >>
> >> >> Loading the quite large JAXB tree takes a few hundred milliseconds.
> >> >>
> >> >> --
> >> >> This message is automatically generated by JIRA.
> >> >> If you think it was sent incorrectly, please contact your JIRA
> >> >> administrators:
> >> >>
> >>
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> >> >> For more information on JIRA, see:
> >> http://www.atlassian.com/software/jira
> >> >>
> >> >>
> >> >>
> >> >
> >>
> >
> >
>
Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default. Only needed for Geronimo
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
here it is ...
Failure: http://ci.apache.org/builders/openejb-trunk-ubuntu/builds/2234
JLouis
Le 25 avril 2012 15:21, Jean-Louis MONTEIRO <je...@gmail.com> a écrit :
> This file is useful for JAX-WS et WSS integration.
> Some examples (and therefor the build I guess) won't work anymore.
>
> Jean-Louis
>
>
> Le 25 avril 2012 15:12, Mark Struberg <st...@yahoo.de> a écrit :
>
> In general I'm +1 for the change.
>>
>> Is there any configuration in TomEE where we could enable the old
>> behaviour with if someone needs it?
>>
>> LieGrue,
>> strub
>>
>>
>>
>> ----- Original Message -----
>> > From: Jean-Louis MONTEIRO <je...@gmail.com>
>> > To: dev@openejb.apache.org
>> > Cc:
>> > Sent: Wednesday, April 25, 2012 2:45 PM
>> > Subject: Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2
>> openejb-jar.xml by default. Only needed for Geronimo
>> >
>> > Don't agree David.
>> >
>> > Saving hundred milliseconds also disabled very interesting features.
>> >
>> > JLouis
>> >
>> >
>> > Le 25 avril 2012 14:42, David Blevins (JIRA) <ji...@apache.org> a écrit
>> :
>> >
>> >> David Blevins created TOMEE-167:
>> >> -----------------------------------
>> >>
>> >> Summary: Disable support for legacy v2 openejb-jar.xml by
>> >> default. Only needed for Geronimo
>> >> Key: TOMEE-167
>> >> URL: https://issues.apache.org/jira/browse/TOMEE-167
>> >> Project: TomEE
>> >> Issue Type: Improvement
>> >> Reporter: David Blevins
>> >> Assignee: David Blevins
>> >> Fix For: 1.0.0
>> >>
>> >>
>> >> Only needed for Geronimo, not needed for TomEE.
>> >>
>> >> Loading the quite large JAXB tree takes a few hundred milliseconds.
>> >>
>> >> --
>> >> This message is automatically generated by JIRA.
>> >> If you think it was sent incorrectly, please contact your JIRA
>> >> administrators:
>> >>
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> >> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>> >>
>> >>
>> >>
>> >
>>
>
>
Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default. Only needed for Geronimo
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
This file is useful for JAX-WS et WSS integration.
Some examples (and therefor the build I guess) won't work anymore.
Jean-Louis
Le 25 avril 2012 15:12, Mark Struberg <st...@yahoo.de> a écrit :
> In general I'm +1 for the change.
>
> Is there any configuration in TomEE where we could enable the old
> behaviour with if someone needs it?
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
> > From: Jean-Louis MONTEIRO <je...@gmail.com>
> > To: dev@openejb.apache.org
> > Cc:
> > Sent: Wednesday, April 25, 2012 2:45 PM
> > Subject: Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2
> openejb-jar.xml by default. Only needed for Geronimo
> >
> > Don't agree David.
> >
> > Saving hundred milliseconds also disabled very interesting features.
> >
> > JLouis
> >
> >
> > Le 25 avril 2012 14:42, David Blevins (JIRA) <ji...@apache.org> a écrit :
> >
> >> David Blevins created TOMEE-167:
> >> -----------------------------------
> >>
> >> Summary: Disable support for legacy v2 openejb-jar.xml by
> >> default. Only needed for Geronimo
> >> Key: TOMEE-167
> >> URL: https://issues.apache.org/jira/browse/TOMEE-167
> >> Project: TomEE
> >> Issue Type: Improvement
> >> Reporter: David Blevins
> >> Assignee: David Blevins
> >> Fix For: 1.0.0
> >>
> >>
> >> Only needed for Geronimo, not needed for TomEE.
> >>
> >> Loading the quite large JAXB tree takes a few hundred milliseconds.
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> If you think it was sent incorrectly, please contact your JIRA
> >> administrators:
> >>
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> >> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >>
> >>
> >>
> >
>
Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2 openejb-jar.xml by default. Only needed for Geronimo
Posted by Mark Struberg <st...@yahoo.de>.
In general I'm +1 for the change.
Is there any configuration in TomEE where we could enable the old behaviour with if someone needs it?
LieGrue,
strub
----- Original Message -----
> From: Jean-Louis MONTEIRO <je...@gmail.com>
> To: dev@openejb.apache.org
> Cc:
> Sent: Wednesday, April 25, 2012 2:45 PM
> Subject: Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2 openejb-jar.xml by default. Only needed for Geronimo
>
> Don't agree David.
>
> Saving hundred milliseconds also disabled very interesting features.
>
> JLouis
>
>
> Le 25 avril 2012 14:42, David Blevins (JIRA) <ji...@apache.org> a écrit :
>
>> David Blevins created TOMEE-167:
>> -----------------------------------
>>
>> Summary: Disable support for legacy v2 openejb-jar.xml by
>> default. Only needed for Geronimo
>> Key: TOMEE-167
>> URL: https://issues.apache.org/jira/browse/TOMEE-167
>> Project: TomEE
>> Issue Type: Improvement
>> Reporter: David Blevins
>> Assignee: David Blevins
>> Fix For: 1.0.0
>>
>>
>> Only needed for Geronimo, not needed for TomEE.
>>
>> Loading the quite large JAXB tree takes a few hundred milliseconds.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>
Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2 openejb-jar.xml by default. Only needed for Geronimo
Posted by David Blevins <da...@gmail.com>.
On Apr 25, 2012, at 5:45 AM, Jean-Louis MONTEIRO wrote:
> Saving hundred milliseconds also disabled very interesting features.
Side note, this no longer has a performance impact one way or another -- the optimization that builds our system apps in code eliminates the openejb-jar.xml that was causing the old descriptor code to be pulled in.
The Openejb2Conversion code will always try to parse any openejb-jar.xml it sees as a v2 file and convert it to a v3 file even if it is a v3 file.
Lot's of things about this section of the code need improvement.
-David
>
> Le 25 avril 2012 14:42, David Blevins (JIRA) <ji...@apache.org> a écrit :
>
>> David Blevins created TOMEE-167:
>> -----------------------------------
>>
>> Summary: Disable support for legacy v2 openejb-jar.xml by
>> default. Only needed for Geronimo
>> Key: TOMEE-167
>> URL: https://issues.apache.org/jira/browse/TOMEE-167
>> Project: TomEE
>> Issue Type: Improvement
>> Reporter: David Blevins
>> Assignee: David Blevins
>> Fix For: 1.0.0
>>
>>
>> Only needed for Geronimo, not needed for TomEE.
>>
>> Loading the quite large JAXB tree takes a few hundred milliseconds.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
Re: [jira] [Created] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default. Only needed for Geronimo
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
Don't agree David.
Saving hundred milliseconds also disabled very interesting features.
JLouis
Le 25 avril 2012 14:42, David Blevins (JIRA) <ji...@apache.org> a écrit :
> David Blevins created TOMEE-167:
> -----------------------------------
>
> Summary: Disable support for legacy v2 openejb-jar.xml by
> default. Only needed for Geronimo
> Key: TOMEE-167
> URL: https://issues.apache.org/jira/browse/TOMEE-167
> Project: TomEE
> Issue Type: Improvement
> Reporter: David Blevins
> Assignee: David Blevins
> Fix For: 1.0.0
>
>
> Only needed for Geronimo, not needed for TomEE.
>
> Loading the quite large JAXB tree takes a few hundred milliseconds.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
Re: [jira] [Commented] (TOMEE-167) Disable support for legacy v2 openejb-jar.xml by default
Posted by David Blevins <da...@gmail.com>.
Looks like it's in the v3 descriptor, just in the form of properties. Openejb2Conversion shows the properties that match the elements
We could/should probably support the exact elements. Would still be properties underneath, but elements look nicer.
-David
On Apr 25, 2012, at 7:10 AM, Jean-Louis MONTEIRO wrote:
> Agree!
> Need to review all descriptors and what is used.
>
> Jean-Louis
>
> Le 25 avril 2012 15:36, David Blevins (JIRA) <ji...@apache.org> a écrit :
>
>>
>> [
>> https://issues.apache.org/jira/browse/TOMEE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261637#comment-13261637]
>>
>> David Blevins commented on TOMEE-167:
>> -------------------------------------
>>
>> Anyway, the v2 openejb-jar.xml pulls in 73 or so JAXB objects and 90% of
>> them only apply to Geronimo.
>>
>> I'll put it back, but we definitely need to cut this out at some point.
>>
>>> Disable support for legacy v2 openejb-jar.xml by default
>>> --------------------------------------------------------
>>>
>>> Key: TOMEE-167
>>> URL: https://issues.apache.org/jira/browse/TOMEE-167
>>> Project: TomEE
>>> Issue Type: Improvement
>>> Reporter: David Blevins
>>> Assignee: David Blevins
>>> Fix For: 1.0.0
>>>
>>>
>>> Only needed for Geronimo, not needed for TomEE.
>>> Loading the quite large JAXB tree takes a few hundred milliseconds.
>>
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
Re: [jira] [Commented] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
Agree!
Need to review all descriptors and what is used.
Jean-Louis
Le 25 avril 2012 15:36, David Blevins (JIRA) <ji...@apache.org> a écrit :
>
> [
> https://issues.apache.org/jira/browse/TOMEE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261637#comment-13261637]
>
> David Blevins commented on TOMEE-167:
> -------------------------------------
>
> Anyway, the v2 openejb-jar.xml pulls in 73 or so JAXB objects and 90% of
> them only apply to Geronimo.
>
> I'll put it back, but we definitely need to cut this out at some point.
>
> > Disable support for legacy v2 openejb-jar.xml by default
> > --------------------------------------------------------
> >
> > Key: TOMEE-167
> > URL: https://issues.apache.org/jira/browse/TOMEE-167
> > Project: TomEE
> > Issue Type: Improvement
> > Reporter: David Blevins
> > Assignee: David Blevins
> > Fix For: 1.0.0
> >
> >
> > Only needed for Geronimo, not needed for TomEE.
> > Loading the quite large JAXB tree takes a few hundred milliseconds.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Commented] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default
Posted by "Jean-Louis MONTEIRO (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TOMEE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261627#comment-13261627 ]
Jean-Louis MONTEIRO commented on TOMEE-167:
-------------------------------------------
-1, useful for webservices and security (WSS and basic I guess).
Examples won't work anymore.
> Disable support for legacy v2 openejb-jar.xml by default
> --------------------------------------------------------
>
> Key: TOMEE-167
> URL: https://issues.apache.org/jira/browse/TOMEE-167
> Project: TomEE
> Issue Type: Improvement
> Reporter: David Blevins
> Assignee: David Blevins
> Fix For: 1.0.0
>
>
> Only needed for Geronimo, not needed for TomEE.
> Loading the quite large JAXB tree takes a few hundred milliseconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TOMEE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins updated TOMEE-167:
--------------------------------
Summary: Disable support for legacy v2 openejb-jar.xml by default (was: Disable support for legacy v2 openejb-jar.xml by default. Only needed for Geronimo)
> Disable support for legacy v2 openejb-jar.xml by default
> --------------------------------------------------------
>
> Key: TOMEE-167
> URL: https://issues.apache.org/jira/browse/TOMEE-167
> Project: TomEE
> Issue Type: Improvement
> Reporter: David Blevins
> Assignee: David Blevins
> Fix For: 1.0.0
>
>
> Only needed for Geronimo, not needed for TomEE.
> Loading the quite large JAXB tree takes a few hundred milliseconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TOMEE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261632#comment-13261632 ]
David Blevins commented on TOMEE-167:
-------------------------------------
How is it we don't have support for that stuff in the new openejb-jar.xml?
> Disable support for legacy v2 openejb-jar.xml by default
> --------------------------------------------------------
>
> Key: TOMEE-167
> URL: https://issues.apache.org/jira/browse/TOMEE-167
> Project: TomEE
> Issue Type: Improvement
> Reporter: David Blevins
> Assignee: David Blevins
> Fix For: 1.0.0
>
>
> Only needed for Geronimo, not needed for TomEE.
> Loading the quite large JAXB tree takes a few hundred milliseconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TOMEE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Blevins closed TOMEE-167.
-------------------------------
Resolution: Fixed
> Disable support for legacy v2 openejb-jar.xml by default
> --------------------------------------------------------
>
> Key: TOMEE-167
> URL: https://issues.apache.org/jira/browse/TOMEE-167
> Project: TomEE
> Issue Type: Improvement
> Reporter: David Blevins
> Assignee: David Blevins
> Fix For: 1.0.0
>
>
> Only needed for Geronimo, not needed for TomEE.
> Loading the quite large JAXB tree takes a few hundred milliseconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TOMEE-167) Disable support for legacy v2
openejb-jar.xml by default
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TOMEE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261637#comment-13261637 ]
David Blevins commented on TOMEE-167:
-------------------------------------
Anyway, the v2 openejb-jar.xml pulls in 73 or so JAXB objects and 90% of them only apply to Geronimo.
I'll put it back, but we definitely need to cut this out at some point.
> Disable support for legacy v2 openejb-jar.xml by default
> --------------------------------------------------------
>
> Key: TOMEE-167
> URL: https://issues.apache.org/jira/browse/TOMEE-167
> Project: TomEE
> Issue Type: Improvement
> Reporter: David Blevins
> Assignee: David Blevins
> Fix For: 1.0.0
>
>
> Only needed for Geronimo, not needed for TomEE.
> Loading the quite large JAXB tree takes a few hundred milliseconds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira