You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Tomás Fernández Löbbe (JIRA)" <ji...@apache.org> on 2019/04/10 16:45:00 UTC
[jira] [Comment Edited] (SOLR-13386) Remove race in
OverseerTaskQueue#remove that can result in the Overseer causing a
Zookeeper call spin spike.
[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814630#comment-16814630 ]
Tomás Fernández Löbbe edited comment on SOLR-13386 at 4/10/19 4:44 PM:
-----------------------------------------------------------------------
Good catch
bq. and treat it the same as exists returning false
Maybe we can just skip the "exists" call? The NoNodeException should not be the normal case. I mean, something like:
{code:java}
try {
zookeeper.setData(responsePath, event.getBytes(), true);
} catch (NoNodeException e) {
log.info("Response path doesn't exist...");
}
{code}
was (Author: tomasflobbe):
Good catch
bq. and treat it the same as exists returning false
Maybe we can just skip the "exists" call? The NoNodeException should not be the normal case.
> Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.
> ------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13386
> URL: https://issues.apache.org/jira/browse/SOLR-13386
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Major
> Fix For: 7.7.2, 8.1
>
>
> If the data call hits NoNodeException, it will throw and the Overseer work queue processor will catch it and loop and repeat, which causes major zk getData / NoNode call traffic or other such things.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org