You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2021/09/02 04:35:32 UTC
[GitHub] [openmeetings] sebawagner opened a new pull request #147: OPENMEETINGS-2420 Update documentation and tagging for documenting Rest API. Sync with website
sebawagner opened a new pull request #147:
URL: https://github.com/apache/openmeetings/pull/147
Update documentation and add annotation for Tag for grouping Rest Services
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner merged pull request #147: OPENMEETINGS-2420 Update documentation and tagging for documenting Rest API. Sync with website
Posted by GitBox <gi...@apache.org>.
sebawagner merged pull request #147:
URL: https://github.com/apache/openmeetings/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #147: OPENMEETINGS-2420 Update documentation and tagging for documenting Rest API. Sync with website
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #147:
URL: https://github.com/apache/openmeetings/pull/147#discussion_r700741586
##########
File path: openmeetings-webservice/pom.xml
##########
@@ -138,6 +138,11 @@
<groupId>org.codehaus.jettison</groupId>
<artifactId>jettison</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.swagger.core.v3</groupId>
+ <artifactId>swagger-annotations</artifactId>
+ <version>2.1.10</version>
Review comment:
could you move version to properties (and generalize where possible)
so i can easier check for updates? :)
##########
File path: openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/NetTestWebService.java
##########
@@ -41,7 +41,16 @@
import org.springframework.beans.factory.annotation.Value;
import org.springframework.stereotype.Service;
+import io.swagger.v3.oas.annotations.tags.Tag;
+
+/**
+ *
Review comment:
redundant line breaks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] sebawagner commented on a change in pull request #147: OPENMEETINGS-2420 Update documentation and tagging for documenting Rest API. Sync with website
Posted by GitBox <gi...@apache.org>.
sebawagner commented on a change in pull request #147:
URL: https://github.com/apache/openmeetings/pull/147#discussion_r700837941
##########
File path: openmeetings-webservice/pom.xml
##########
@@ -138,6 +138,11 @@
<groupId>org.codehaus.jettison</groupId>
<artifactId>jettison</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.swagger.core.v3</groupId>
+ <artifactId>swagger-annotations</artifactId>
+ <version>2.1.10</version>
Review comment:
Done
##########
File path: openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/NetTestWebService.java
##########
@@ -41,7 +41,16 @@
import org.springframework.beans.factory.annotation.Value;
import org.springframework.stereotype.Service;
+import io.swagger.v3.oas.annotations.tags.Tag;
+
+/**
+ *
Review comment:
Done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org