You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/02 19:19:49 UTC

[GitHub] [druid] gianm opened a new pull request #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)

gianm opened a new pull request #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)
URL: https://github.com/apache/druid/pull/9118
 
 
   Backport of #9098 to 0.17.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)

Posted by GitBox <gi...@apache.org>.
gianm commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)
URL: https://github.com/apache/druid/pull/9118#issuecomment-570641257
 
 
   I've backported #9120 to 0.17.0, merged that branch here, and re-pushed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)

Posted by GitBox <gi...@apache.org>.
gianm commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)
URL: https://github.com/apache/druid/pull/9118#issuecomment-570389613
 
 
   Is the branch broken? It seems strange that S3 changes would cause that test to fail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jihoonson commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)

Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)
URL: https://github.com/apache/druid/pull/9118#issuecomment-570369816
 
 
   The CI failure looks legit:
   
   ```
   [ERROR] Failures: 
   
   [ERROR] org.apache.druid.query.aggregation.distinctcount.DistinctCountGroupByQueryTest.testGroupByWithDistinctCountAgg(org.apache.druid.query.aggregation.distinctcount.DistinctCountGroupByQueryTest)
   
   [ERROR]   Run 1: DistinctCountGroupByQueryTest.testGroupByWithDistinctCountAgg:156 distinct-count: Expected expectedResultsIter to be exhausted, next element was ResultRow{row=[iphone, 2, 2]}
   
   [ERROR]   Run 2: DistinctCountGroupByQueryTest.testGroupByWithDistinctCountAgg:156 distinct-count: Expected expectedResultsIter to be exhausted, next element was ResultRow{row=[iphone, 2, 2]}
   
   [ERROR]   Run 3: DistinctCountGroupByQueryTest.testGroupByWithDistinctCountAgg:156 distinct-count: Expected expectedResultsIter to be exhausted, next element was ResultRow{row=[iphone, 2, 2]}
   
   [ERROR]   Run 4: DistinctCountGroupByQueryTest.testGroupByWithDistinctCountAgg:156 distinct-count: Expected expectedResultsIter to be exhausted, next element was ResultRow{row=[iphone, 2, 2]}
   
   [INFO] 
   
   [INFO] 
   
   [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)

Posted by GitBox <gi...@apache.org>.
gianm commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)
URL: https://github.com/apache/druid/pull/9118#issuecomment-570416372
 
 
   Actually, master is broken… I see the same failure there. It looks like a Y2020 bug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] fjy merged pull request #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)

Posted by GitBox <gi...@apache.org>.
fjy merged pull request #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)
URL: https://github.com/apache/druid/pull/9118
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)

Posted by GitBox <gi...@apache.org>.
gianm commented on issue #9118: [Backport] S3: Improvements to prefix listing (including fix for an infinite loop)
URL: https://github.com/apache/druid/pull/9118#issuecomment-570417161
 
 
   https://github.com/apache/druid/pull/9120

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org