You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by machard <gi...@git.apache.org> on 2014/08/06 10:37:23 UTC

[GitHub] cordova-plugin-inappbrowser pull request: inappbrowser events supp...

GitHub user machard opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/57

    inappbrowser events supported for _blank target

    Hi,
    
    It adds the standard events for firefoxos.
    
    Unfortunately it's only for _blank target as origOpenFunc.apply(window, [strUrl, '_blank']); returns null..

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/machard/cordova-plugin-inappbrowser events_suppport

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit c2c94f315b956a6179d45013b30653b4689ad19d
Author: Tracktl <tr...@macbook-pro-de-tracktl.local>
Date:   2014-08-05T13:50:49Z

    phonegap events supported for _blank target

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: inappbrowser events supp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-plugin-inappbrowser pull request: inappbrowser events supp...

Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/57#issuecomment-53558383
  
    Thanks! r+


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---