[GitHub] [trafficserver] serrislew commented on a diff in pull request #9334: Fix an error on SSL config reload (plus some cleanup).

["serrislew (via GitHub)" <gi...@apache.org>]

serrislew commented on code in PR #9334:
URL: https://github.com/apache/trafficserver/pull/9334#discussion_r1089264957


##########
iocore/net/SSLUtils.cc:
##########
@@ -1053,8 +1053,8 @@ SSLPrivateKeyHandler(SSL_CTX *ctx, const SSLConfigParams *params, const char *ke
     scoped_BIO bio(BIO_new_mem_buf(secret_data, secret_data_len));
     pkey = PEM_read_bio_PrivateKey(bio.get(), nullptr, nullptr, nullptr);
     if (nullptr == pkey) {
-      Debug("ssl_load", "failed to load server private key from %s",
-            (!keyPath || keyPath[0] == '\0') ? "[empty key path]" : keyPath);
+      SSLError("failed to load server private key (%.*s) from %s", secret_data_len < 50 ? secret_data_len : 50, secret_data,

Review Comment:
   It still calls a SSLError log https://github.com/apache/trafficserver/pull/9225/files#diff-cb865c0bc65fb8ef103a206282b78a50e0c1c9e93ca6713322ba9df9d921e6c9L2453



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org