You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/01 20:33:58 UTC

[GitHub] [beam] ryanthompson591 commented on a diff in pull request #17470: [BEAM-14337] Support **kwargs for PyTorch models

ryanthompson591 commented on code in PR #17470:
URL: https://github.com/apache/beam/pull/17470#discussion_r887260080


##########
sdks/python/apache_beam/ml/inference/base_test.py:
##########
@@ -39,7 +39,7 @@ class FakeInferenceRunner(base.InferenceRunner):
   def __init__(self, clock=None):
     self._mock_clock = clock
 
-  def run_inference(self, batch: Any, model: Any) -> Iterable[Any]:
+  def run_inference(self, batch: Any, model: Any, **kwargs) -> Iterable[Any]:

Review Comment:
   I suggest a small unit test just to make sure these parameters get passed through to the inference runner.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org