You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/29 21:36:48 UTC

[GitHub] [incubator-pinot] mqliang opened a new issue #6727: Set up a pipeline or maven plugin to enforce java format

mqliang opened a new issue #6727:
URL: https://github.com/apache/incubator-pinot/issues/6727


   There are lots of files are not formatted properly, engineers often forget to format it before commit. We need either setup a Github workflow/pipeline, or a maven plugin to enforce java format
   
   Some tools may be useful:
   
   CLI tools: 
   * https://github.com/google/google-java-format
   
   Maven plugins:
   * https://github.com/diffplug/spotless/tree/main/plugin-maven
   * https://github.com/coveooss/fmt-maven-plugin
   * https://github.com/talios/googleformatter-maven-plugin
   * https://github.com/Cosium/git-code-format-maven-plugin
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] fx19880617 commented on issue #6727: Set up a pipeline or maven plugin to enforce java format

Posted by GitBox <gi...@apache.org>.
fx19880617 commented on issue #6727:
URL: https://github.com/apache/incubator-pinot/issues/6727#issuecomment-809739272


   Thanks for bringing this up!
   
   +1000 on this, I think a maven plugin should be good enough.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org