You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/21 09:58:44 UTC
[GitHub] [flink] fsk119 opened a new pull request #14444: [Flink-20091][avro] add ignore-parse-error for
fsk119 opened a new pull request #14444:
URL: https://github.com/apache/flink/pull/14444
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Add ignore-parse-error for avro format, avro-confluent.*
## Brief change log
- *move the option IGNORE_PARSE_ERROR to FactoryUtil*
- *add the option IGNORE_PARSE_ERROR for avro and avro-confluent*
## Verifying this change
This change added tests and can be verified as follows:
- *test when parsing record with the decoder whose schema is different*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14444:
URL: https://github.com/apache/flink/pull/14444#discussion_r547049153
##########
File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDataDeserializationSchema.java
##########
@@ -85,9 +88,27 @@ public AvroRowDataDeserializationSchema(
DeserializationSchema<GenericRecord> nestedSchema,
AvroToRowDataConverters.AvroToRowDataConverter runtimeConverter,
TypeInformation<RowData> typeInfo) {
+ this(nestedSchema, runtimeConverter, typeInfo, false);
+ }
+
+ /**
+ * Creates a Avro deserialization schema for the given logical type.
+ *
+ * @param nestedSchema Deserialization schema to deserialize as {@link GenericRecord}
+ * @param runtimeConverter Converter that transforms a {@link GenericRecord} into {@link RowData}
+ * @param typeInfo The TypeInformation to be used by
+ * {@link AvroRowDataDeserializationSchema#getProducedType()}
+ * @param ignoreParseError Indicate whether to skip rows with parsing error
+ */
+ public AvroRowDataDeserializationSchema(
Review comment:
I would suggest to refactor this class into builder pattern. It's hard to maintain to introduce a new constructor when adding a new parameter.
##########
File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDataDeserializationSchema.java
##########
@@ -59,18 +59,21 @@
*/
private final AvroToRowDataConverters.AvroToRowDataConverter runtimeConverter;
+ private final Boolean ignoreParseError;
Review comment:
Use primitive type `boolean` otherwise, it maybe `null`.
##########
File path: flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowDataDeSerializationSchemaTest.java
##########
@@ -205,4 +207,26 @@ public void testSpecificType() throws Exception {
Assert.assertEquals("12:12:12", DataFormatConverters.LocalTimeConverter.INSTANCE.toExternal(
rowData.getInt(2)).toString());
}
+
+ @Test
+ public void testIgnoreParseErrors() throws Exception {
+ DataType serDataType = ROW(FIELD("type_int", INT().notNull())).notNull();
+ RowType serRowType = (RowType) serDataType.getLogicalType();
+ AvroRowDataSerializationSchema serializationSchema = new AvroRowDataSerializationSchema(serRowType);
+ serializationSchema.open(null);
+ RowData input = GenericRowData.of(1);
+ byte[] byteData = serializationSchema.serialize(input);
+
+ DataType deserDataType = ROW(FIELD("type_int", DOUBLE().notNull())).notNull();
+ RowType deserRowType = (RowType) deserDataType.getLogicalType();
+ AvroRowDataDeserializationSchema deserializationSchema = new AvroRowDataDeserializationSchema(
+ AvroDeserializationSchema.forGeneric(AvroSchemaConverter.convertToSchema(deserRowType)),
+ AvroToRowDataConverters.createRowConverter(deserRowType),
+ InternalTypeInfo.of(deserRowType),
+ true);
+
+ deserializationSchema.open(null);
+ RowData actual = deserializationSchema.deserialize(byteData);
+ assertThat(actual, org.hamcrest.core.IsNull.nullValue(RowData.class));
Review comment:
Why not use `assertNull(actual)` here?
##########
File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDataDeserializationSchema.java
##########
@@ -85,9 +88,27 @@ public AvroRowDataDeserializationSchema(
DeserializationSchema<GenericRecord> nestedSchema,
AvroToRowDataConverters.AvroToRowDataConverter runtimeConverter,
TypeInformation<RowData> typeInfo) {
+ this(nestedSchema, runtimeConverter, typeInfo, false);
+ }
+
+ /**
+ * Creates a Avro deserialization schema for the given logical type.
+ *
+ * @param nestedSchema Deserialization schema to deserialize as {@link GenericRecord}
+ * @param runtimeConverter Converter that transforms a {@link GenericRecord} into {@link RowData}
+ * @param typeInfo The TypeInformation to be used by
+ * {@link AvroRowDataDeserializationSchema#getProducedType()}
+ * @param ignoreParseError Indicate whether to skip rows with parsing error
+ */
+ public AvroRowDataDeserializationSchema(
Review comment:
Besides, this class should be `@Internal` and not `@PublicEvolving`.
##########
File path: flink-formats/flink-avro/src/test/java/org/apache/flink/formats/avro/AvroRowDataDeSerializationSchemaTest.java
##########
@@ -205,4 +207,26 @@ public void testSpecificType() throws Exception {
Assert.assertEquals("12:12:12", DataFormatConverters.LocalTimeConverter.INSTANCE.toExternal(
rowData.getInt(2)).toString());
}
+
+ @Test
+ public void testIgnoreParseErrors() throws Exception {
+ DataType serDataType = ROW(FIELD("type_int", INT().notNull())).notNull();
+ RowType serRowType = (RowType) serDataType.getLogicalType();
+ AvroRowDataSerializationSchema serializationSchema = new AvroRowDataSerializationSchema(serRowType);
+ serializationSchema.open(null);
+ RowData input = GenericRowData.of(1);
+ byte[] byteData = serializationSchema.serialize(input);
Review comment:
Would be better to using numberic type to deseriazing string type to verify the parse error. For example:
deserializing `[int: 1, string: abc]` with schema `(int, long)` should get `Row(1, null)`.
I think deserializing null field is not a strong enough test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
}, {
"hash" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125",
"triggerID" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"triggerType" : "PUSH"
}, {
"hash" : "5acccd8613e6b0af2bca011b851500ad372add6b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11148",
"triggerID" : "5acccd8613e6b0af2bca011b851500ad372add6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125)
* 5acccd8613e6b0af2bca011b851500ad372add6b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11148)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 commented on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for avro formats
Posted by GitBox <gi...@apache.org>.
fsk119 commented on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-948210311
I am recently busy working in the inner branch. I think I have no time to finish this PR....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
}, {
"hash" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 779a0232e0409050e6a1a49874aa06493f90dd7e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120)
* 0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2e10a062a779aabc7717c643623c74ff4cbd5cb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for avro formats
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
}, {
"hash" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125",
"triggerID" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"triggerType" : "PUSH"
}, {
"hash" : "5acccd8613e6b0af2bca011b851500ad372add6b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11148",
"triggerID" : "5acccd8613e6b0af2bca011b851500ad372add6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5acccd8613e6b0af2bca011b851500ad372add6b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11148)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
}, {
"hash" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125",
"triggerID" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for avro formats
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-940782403
@fsk119 Do you still want to complete this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for avro formats
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
}, {
"hash" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125",
"triggerID" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"triggerType" : "PUSH"
}, {
"hash" : "5acccd8613e6b0af2bca011b851500ad372add6b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11148",
"triggerID" : "5acccd8613e6b0af2bca011b851500ad372add6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5acccd8613e6b0af2bca011b851500ad372add6b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11148)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2e10a062a779aabc7717c643623c74ff4cbd5cb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112)
* 779a0232e0409050e6a1a49874aa06493f90dd7e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2e10a062a779aabc7717c643623c74ff4cbd5cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2e10a062a779aabc7717c643623c74ff4cbd5cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2e10a062a779aabc7717c643623c74ff4cbd5cb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112)
* 779a0232e0409050e6a1a49874aa06493f90dd7e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
}, {
"hash" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125",
"triggerID" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"triggerType" : "PUSH"
}, {
"hash" : "5acccd8613e6b0af2bca011b851500ad372add6b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5acccd8613e6b0af2bca011b851500ad372add6b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125)
* 5acccd8613e6b0af2bca011b851500ad372add6b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14444: [FLINK-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748895134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11112",
"triggerID" : "e2e10a062a779aabc7717c643623c74ff4cbd5cb",
"triggerType" : "PUSH"
}, {
"hash" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120",
"triggerID" : "779a0232e0409050e6a1a49874aa06493f90dd7e",
"triggerType" : "PUSH"
}, {
"hash" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125",
"triggerID" : "0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 779a0232e0409050e6a1a49874aa06493f90dd7e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11120)
* 0c38fb1f30ebb9cc7e060fe2f0599d4a879b80c1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11125)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14444: [Flink-20091][avro] add ignore-parse-error for
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14444:
URL: https://github.com/apache/flink/pull/14444#issuecomment-748886111
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e2e10a062a779aabc7717c643623c74ff4cbd5cb (Mon Dec 21 10:00:47 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fsk119 closed pull request #14444: [FLINK-20091][avro] add ignore-parse-error for avro formats
Posted by GitBox <gi...@apache.org>.
fsk119 closed pull request #14444:
URL: https://github.com/apache/flink/pull/14444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org