You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/03 08:33:01 UTC

[GitHub] [arrow-datafusion] Igosuki commented on a change in pull request #1733: Arrow2 test fix

Igosuki commented on a change in pull request #1733:
URL: https://github.com/apache/arrow-datafusion/pull/1733#discussion_r798325459



##########
File path: datafusion/src/physical_plan/expressions/cast.rs
##########
@@ -105,6 +105,7 @@ pub fn cast_with_error(
 ) -> Result<Box<dyn Array>> {
     let result = cast::cast(array, cast_type, options)?;
     if result.null_count() != array.null_count() {
+        println!("{result:?} : {array:?}");

Review comment:
       > Left one minor comment, the rest looks good to me. Thanks @Igosuki for this work. Sorry that I wasn't able to help with the migration last weekend because something urgent came up :(
   
   Np, I'm actually fixing some of the issues in this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org