[GitHub] [commons-io] michael-o commented on a change in pull request #101: IO-649 - Improve the performance of the contentEquals() methods.

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #101: IO-649 - Improve the performance of the contentEquals() methods.
URL: https://github.com/apache/commons-io/pull/101#discussion_r365984302
 
 

 ##########
 File path: src/main/java/org/apache/commons/io/IOUtils.java
 ##########
 @@ -708,31 +706,79 @@ public static void closeQuietly(final Writer output) {
     @SuppressWarnings("resource")
     public static boolean contentEquals(final InputStream input1, final InputStream input2)
             throws IOException {
+        return contentEquals(input1, input2, DEFAULT_BUFFER_SIZE);
+    }
+
+    /**
+     * Compares the contents of two Streams to determine if they are equal or not.
+     * <p>
+     * This method buffers the input internally.
+     *
+     * @param input1 the first stream
+     * @param input2 the second stream
+     * @param bufferSize the size of the internal buffer to use.
+     * @return true if the content of the streams are equal or they both don't
+     * exist, false otherwise
+     * @throws NullPointerException if either input is null
 
 Review comment:
   I fail to see where this one is thrown.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services