You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/08/01 06:11:21 UTC

[GitHub] [spark] advancedxy commented on a diff in pull request #42255: [SPARK-40178][SQL] Support string parameters in hint method

advancedxy commented on code in PR #42255:
URL: https://github.com/apache/spark/pull/42255#discussion_r1280149294


##########
python/pyspark/sql/tests/test_dataframe.py:
##########
@@ -645,6 +645,35 @@ def test_generic_hints(self):
             df1.join(df2.hint("broadcast"), "id").explain(True)
             self.assertEqual(1, buf.getvalue().count("BroadcastHashJoin"))
 
+    def test_partitioning_hint_with_columns(self):

Review Comment:
   This UT comes from #37616, credits should go to @mhconradt



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org