[GitHub] [flink] azagrebin edited a comment on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager

[GitBox <gi...@apache.org>]

azagrebin edited a comment on issue #8646: [FLINK-12735][network] Make shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#issuecomment-506313023
 
 
   @StephanEwen Thanks for bringing this up.
   
   As @zhijiangW already described, true, the idea was to drop `IOManager` dependency in Shuffle Service API because `NettyShuffleEnviroment` basically uses only narrowed scope of IOManager, namely switching between temporary files.
   
   The valid concern is that if we decide to use `IOManagerAsync` with its threads then the threads should be shared by all IO components which use them. In that case Shuffle Service API has to accept it as a dependency created outside.
   
   As discussed offline, if we decide later that we need `IOManagerAsync` for shuffling then we can revert the change and add the abstract/interface `IOManager` back to `ShuffleEnvironmentContext`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services