[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5136: net/icmp: post the semaphore if multiple references

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5136:
URL: https://github.com/apache/incubator-nuttx/pull/5136#discussion_r777124343



##########
File path: net/icmp/icmp_conn.c
##########
@@ -165,8 +165,9 @@ void icmp_free(FAR struct icmp_conn_s *conn)
       /* Free the connection */
 
       dq_addlast(&conn->node, &g_free_icmp_connections);
-      nxsem_post(&g_free_sem);
     }
+
+  nxsem_post(&g_free_sem);

Review comment:
       does icmpv6 has the similar issue?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org