You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "mattyb149 (via GitHub)" <gi...@apache.org> on 2023/05/10 20:03:46 UTC

[GitHub] [nifi] mattyb149 opened a new pull request, #7236: NIFI-11537: Add support for Iceberg tables to UpdateHive3Table

mattyb149 opened a new pull request, #7236:
URL: https://github.com/apache/nifi/pull/7236

   # Summary
   
   [NIFI-11537](https://issues.apache.org/jira/browse/NIFI-11537) This PR adds a Create Table Storage Handler property to UpdateHive3Table with initial options default (to do nothing) and Iceberg (to generate a CREATE TABLE statement specific to Iceberg-backed tables.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-11537`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-11537`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [x] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [x] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 closed pull request #7236: NIFI-11537: Add support for Iceberg tables to UpdateHive3Table

Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 closed pull request #7236: NIFI-11537: Add support for Iceberg tables to UpdateHive3Table
URL: https://github.com/apache/nifi/pull/7236


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #7236: NIFI-11537: Add support for Iceberg tables to UpdateHive3Table

Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7236:
URL: https://github.com/apache/nifi/pull/7236#issuecomment-1548327414

   Apache Hive 3.1.3 (the current version used in Apache NiFi) doesn't support `STORED BY` and `STORED AS` at the same time. Need to change the logic (for now) to use `STORED BY` if present and `STORED AS` otherwise, plus any other TBLPROPERTIES settings needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #7236: NIFI-11537: Add support for Iceberg tables to UpdateHive3Table

Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7236:
URL: https://github.com/apache/nifi/pull/7236#issuecomment-1572317813

   Closing this PR and the Jira case, the Iceberg support in Apache Hive 3.1.3 isn't complete enough to warrant this effort. The storage format can't be specified and columns can't be added (these capabilities will be added in Hive 4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org