You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2012/11/15 19:02:11 UTC
[jira] [Created] (KAFKA-614) DumpLogSegment offset verification is
incorrect for compressed messages
Jun Rao created KAFKA-614:
-----------------------------
Summary: DumpLogSegment offset verification is incorrect for compressed messages
Key: KAFKA-614
URL: https://issues.apache.org/jira/browse/KAFKA-614
Project: Kafka
Issue Type: Bug
Components: core
Affects Versions: 0.8
Reporter: Jun Rao
During verification, DumpLogSegment tries to make sure that offsets are consecutive. However, this won't be true for compressed messages since FileMessageSet only does shallow iteration. The simplest fix is to skip the verification for compressed messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-614) DumpLogSegment offset verification is
incorrect for compressed messages
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-614:
--------------------------
Attachment: (was: kafka_614_v1.patch)
> DumpLogSegment offset verification is incorrect for compressed messages
> -----------------------------------------------------------------------
>
> Key: KAFKA-614
> URL: https://issues.apache.org/jira/browse/KAFKA-614
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: newbie
> Attachments: kafka_614_v1.patch
>
>
> During verification, DumpLogSegment tries to make sure that offsets are consecutive. However, this won't be true for compressed messages since FileMessageSet only does shallow iteration. The simplest fix is to skip the verification for compressed messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-614) DumpLogSegment offset verification is
incorrect for compressed messages
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-614:
--------------------------
Attachment: kafka_614_v1.patch
kafka_614_v1.patch
> DumpLogSegment offset verification is incorrect for compressed messages
> -----------------------------------------------------------------------
>
> Key: KAFKA-614
> URL: https://issues.apache.org/jira/browse/KAFKA-614
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: newbie
> Attachments: kafka_614_v1.patch
>
>
> During verification, DumpLogSegment tries to make sure that offsets are consecutive. However, this won't be true for compressed messages since FileMessageSet only does shallow iteration. The simplest fix is to skip the verification for compressed messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KAFKA-614) DumpLogSegment offset verification is
incorrect for compressed messages
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao resolved KAFKA-614.
---------------------------
Resolution: Fixed
Fix Version/s: 0.8
Thanks for the patch. +1 and committed to 0.8.
> DumpLogSegment offset verification is incorrect for compressed messages
> -----------------------------------------------------------------------
>
> Key: KAFKA-614
> URL: https://issues.apache.org/jira/browse/KAFKA-614
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: newbie
> Fix For: 0.8
>
> Attachments: kafka_614_v1.patch
>
>
> During verification, DumpLogSegment tries to make sure that offsets are consecutive. However, this won't be true for compressed messages since FileMessageSet only does shallow iteration. The simplest fix is to skip the verification for compressed messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-614) DumpLogSegment offset verification
is incorrect for compressed messages
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506070#comment-13506070 ]
Jun Rao commented on KAFKA-614:
-------------------------------
Thanks for the second patch. Committed to 0.8.
> DumpLogSegment offset verification is incorrect for compressed messages
> -----------------------------------------------------------------------
>
> Key: KAFKA-614
> URL: https://issues.apache.org/jira/browse/KAFKA-614
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: newbie
> Fix For: 0.8
>
> Attachments: dump_fix.diff, kafka_614_v1.patch
>
>
> During verification, DumpLogSegment tries to make sure that offsets are consecutive. However, this won't be true for compressed messages since FileMessageSet only does shallow iteration. The simplest fix is to skip the verification for compressed messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (KAFKA-614) DumpLogSegment offset verification is
incorrect for compressed messages
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao closed KAFKA-614.
-------------------------
> DumpLogSegment offset verification is incorrect for compressed messages
> -----------------------------------------------------------------------
>
> Key: KAFKA-614
> URL: https://issues.apache.org/jira/browse/KAFKA-614
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: newbie
> Fix For: 0.8
>
> Attachments: kafka_614_v1.patch
>
>
> During verification, DumpLogSegment tries to make sure that offsets are consecutive. However, this won't be true for compressed messages since FileMessageSet only does shallow iteration. The simplest fix is to skip the verification for compressed messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-614) DumpLogSegment offset verification is
incorrect for compressed messages
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-614:
--------------------------
Attachment: dump_fix.diff
Dump Log segment too continue patch
> DumpLogSegment offset verification is incorrect for compressed messages
> -----------------------------------------------------------------------
>
> Key: KAFKA-614
> URL: https://issues.apache.org/jira/browse/KAFKA-614
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: newbie
> Fix For: 0.8
>
> Attachments: dump_fix.diff, kafka_614_v1.patch
>
>
> During verification, DumpLogSegment tries to make sure that offsets are consecutive. However, this won't be true for compressed messages since FileMessageSet only does shallow iteration. The simplest fix is to skip the verification for compressed messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira