[GitHub] [incubator-hudi] cdmikechen commented on a change in pull request #1159: HUDI-479: Eliminate or Minimize use of Guava if possible

[GitBox <gi...@apache.org>]

cdmikechen commented on a change in pull request #1159: HUDI-479: Eliminate or Minimize use of Guava if possible
URL: https://github.com/apache/incubator-hudi/pull/1159#discussion_r362128256
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/BloomIndexFileInfo.java
 ##########
 @@ -78,22 +77,24 @@ public boolean equals(Object o) {
     }
 
     BloomIndexFileInfo that = (BloomIndexFileInfo) o;
-    return Objects.equal(that.fileId, fileId) && Objects.equal(that.minRecordKey, minRecordKey)
-        && Objects.equal(that.maxRecordKey, maxRecordKey);
+    return Objects.equals(that.fileId, fileId) && Objects.equals(that.minRecordKey, minRecordKey)
+        && Objects.equals(that.maxRecordKey, maxRecordKey);
 
   }
 
   @Override
   public int hashCode() {
-    return Objects.hashCode(fileId, minRecordKey, maxRecordKey);
+    return Objects.hash(fileId, minRecordKey, maxRecordKey);
   }
 
   public String toString() {
-    final StringBuilder sb = new StringBuilder("BloomIndexFileInfo {");
-    sb.append(" fileId=").append(fileId);
-    sb.append(" minRecordKey=").append(minRecordKey);
-    sb.append(" maxRecordKey=").append(maxRecordKey);
-    sb.append('}');
-    return sb.toString();
+    return "BloomIndexFileInfo {"
 
 Review comment:
   I think original method may be OK. Do we have to modify it or not?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services