You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/09/15 19:47:30 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #15762: [TVMScript] Use environment variable TVM_BLACK_FORMAT for .show()
Lunderberg opened a new pull request, #15762:
URL: https://github.com/apache/tvm/pull/15762
Prior to this commit, the default behavior of the `black_format` argument in TVMScript printing has changed back and forth, based on conflicting user preferences. This commit allows the default to be specified by each using using the `TVM_BLACK_FORMAT` environment variable. If unspecified in a `obj.show()` method call, this environment variable is used to determine the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #15762: [TVMScript] Use environment variable TVM_BLACK_FORMAT for .show()
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #15762:
URL: https://github.com/apache/tvm/pull/15762#issuecomment-1721979373
BTW, `line_length` is something we could configure in black: https://github.com/psf/black/blob/19.3b0/black.py#L168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg merged pull request #15762: [TVMScript] Use environment variable TVM_BLACK_FORMAT for .show()
Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg merged PR #15762:
URL: https://github.com/apache/tvm/pull/15762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #15762: [TVMScript] Use environment variable TVM_BLACK_FORMAT for .show()
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #15762:
URL: https://github.com/apache/tvm/pull/15762#issuecomment-1722143981
Great PR! It's a great solution to make people with different tastes happy! Thanks @Lunderberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #15762: [TVMScript] Use environment variable TVM_BLACK_FORMAT for .show()
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #15762:
URL: https://github.com/apache/tvm/pull/15762#issuecomment-1721978647
Love this PR. Moving my comments from the [previous one](https://github.com/apache/tvm/pull/15706#issuecomment-1721978241).
> Thanks @Lunderberg! 100% agreed with your comments, and particularly, feeling the same as you that the previous generation of TVMScript printer comes with many subtle issues making it not good looking or non-pythonic at all, as you mentioned, extra parentheses, non-fused loops, and ramp/broadcast syntax. The environment variable based approach is even better to me. Happy to get it in!
>
> I have been thinking about this issue as well in the recent days, as it's something we all care about a lot. I think all of us agree with the formatting perspective, and my personal source of pain is mainly about the line width. How about @Hzfengsy? If line-width is the only thing we have different opinions, we can make it configurable using an environment variable.
>
> Let's also move the discussion to @Lunderberg's new PR for more visbility!
>
> Thanks again Eric for being always super thoughtful!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org