[GitHub] [samza] rmatharu opened a new pull request #1234: Adding null-check before incrementing metrics for bytesSerialized

[GitBox <gi...@apache.org>]

rmatharu opened a new pull request #1234: Adding null-check before incrementing metrics for bytesSerialized
URL: https://github.com/apache/samza/pull/1234
 
 
   Adding null-check before incrementing metrics for bytesSerialized
   
   Symptom: User serde-serialization logic can choose to serialize non-null objects to a null, which implies delete the value. In this case, current code tries to increment the metrics using the size of the null and fails with an NPE.
   
   Cause: Current code tries to increment the bytesSerialized metrics using the size of the null and fails with an NPE.
   
   Fix: Added logic to skip metric value update if serde returns null.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services