You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/11 00:36:01 UTC
Review Request 43437: Update slave tests to pass shared_ptrs to
'StartSlave'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43437/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Bugs: MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4633
Repository: mesos
Description
-------
Makes the following changes:
* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated dependency.
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and `dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.
Diffs
-----
src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67
src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a
Diff: https://reviews.apache.org/r/43437/diff/
Testing
-------
Tests are run at the very, very end of this review chain.
Thanks,
Joseph Wu
Re: Review Request 43437: Update slave tests to pass shared_ptrs to
'StartSlave'.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43437/
-----------------------------------------------------------
(Updated Feb. 11, 2016, 11:33 a.m.)
Review request for mesos, Bernd Mathiske and Artem Harutyunyan.
Changes
-------
Move some FUTURE_DISPATCH's on the MesosContainerizer after the destruction of a prior containerizer.
Bugs: MESOS-4633
https://issues.apache.org/jira/browse/MESOS-4633
Repository: mesos
Description
-------
Makes the following changes:
* All objects passed to `StartSlave` are transformed into `shared_ptr`.
* References to the above objects are updated to reflect the different type.
* Removes `Shutdown()` in at the end of all tests, except for master tests that have a stack-allocated dependency.
* Removes manual `delete`s inside tests.
* Generally renames test variables to be more consistent (i.e. `exec` -> `executor` and `dockerContainerizer` -> `containerizer`).
* Removes extraneous spaces in `Try<PID<Slave> >` in touched lines.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67
src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a
Diff: https://reviews.apache.org/r/43437/diff/
Testing
-------
Tests are run at the very, very end of this review chain.
Thanks,
Joseph Wu