You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sun Dapeng <da...@intel.com> on 2014/07/22 10:05:41 UTC

Review Request 23798: SENTRY-349 Extend Hive Hook with Grant Option

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23798/
-----------------------------------------------------------

Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.


Repository: sentry


Description
-------

The patch is depended on 'SENTRY-345: Revoke check with grant option'
The patch contains:
1. Accepted grantOption when grant and revoke in SentryGrantRevokeTask.
2. Added grant/revoke override interfaces with grant option in SentryPolicyServiceClient.
3. Added two testcases.


Diffs
-----

  sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 27a10ee 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 5fd4f8f 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java a4ae291 

Diff: https://reviews.apache.org/r/23798/diff/


Testing
-------

Unit tests in local


Thanks,

Sun Dapeng

Re: Review Request 23798: SENTRY-349 Extend Hive Hook with Grant Option

Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23798/
-----------------------------------------------------------

(Updated July 31, 2014, 6:42 p.m.)


Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.


Changes
-------

Removed sentry limits


Repository: sentry


Description
-------

The patch is depended on 'SENTRY-345: Revoke check with grant option'
The patch contains:
1. Accepted grantOption when grant and revoke in SentryGrantRevokeTask.
2. Added grant/revoke override interfaces with grant option in SentryPolicyServiceClient.
3. Added two testcases.


Diffs (updated)
-----

  sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java 26eea91 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 27a10ee 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 991d734 
  sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java ac0d170 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryNoGrantOpitonException.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 5fd4f8f 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 3bb7285 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java a4ae291 

Diff: https://reviews.apache.org/r/23798/diff/


Testing
-------

Unit tests in local


Thanks,

Sun Dapeng

Re: Review Request 23798: SENTRY-349 Extend Hive Hook with Grant Option

Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23798/
-----------------------------------------------------------

(Updated July 28, 2014, 6:02 p.m.)


Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.


Changes
-------

Change code base on SENTRY-339


Repository: sentry


Description
-------

The patch is depended on 'SENTRY-345: Revoke check with grant option'
The patch contains:
1. Accepted grantOption when grant and revoke in SentryGrantRevokeTask.
2. Added grant/revoke override interfaces with grant option in SentryPolicyServiceClient.
3. Added two testcases.


Diffs (updated)
-----

  sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 27a10ee 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 5fd4f8f 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java a4ae291 

Diff: https://reviews.apache.org/r/23798/diff/


Testing
-------

Unit tests in local


Thanks,

Sun Dapeng