You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/07/22 12:09:55 UTC

[isis] branch master updated: ISIS-2815: sonar: Delivering code in production with debug features activated is security-sensitiv

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new e86b47f  ISIS-2815: sonar: Delivering code in production with debug features activated is security-sensitiv
e86b47f is described below

commit e86b47f7f1295eb22f32bf8a053ad9fbfb715f0d
Author: Andi Huber <ah...@apache.org>
AuthorDate: Thu Jul 22 14:09:46 2021 +0200

    ISIS-2815: sonar: Delivering code in production with debug features
    activated is security-sensitiv
---
 .../apache/isis/core/metamodel/services/grid/GridReaderUsingJaxb.java | 4 ++--
 .../apache/isis/core/metamodel/services/menubars/menubars.layout.xml  | 0
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/grid/GridReaderUsingJaxb.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/grid/GridReaderUsingJaxb.java
index 8f356ca..02583f6 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/grid/GridReaderUsingJaxb.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/services/grid/GridReaderUsingJaxb.java
@@ -71,7 +71,7 @@ public class GridReaderUsingJaxb {
         }
     }
 
-    public Grid loadGrid(String xml) {
+    public Grid loadGrid(final String xml) {
         initForTesting(); // a no-op if already initialized via @PostConstruct
         return (Grid) jaxbService.fromXml(jaxbContext, xml);
     }
@@ -84,7 +84,7 @@ public class GridReaderUsingJaxb {
             try {
                 jaxbContext = JAXBContext.newInstance(BS3Grid.class);
             } catch (JAXBException e) {
-                e.printStackTrace();
+                // leave as null
             }
         }
     }
diff --git a/core/metamodel/src/test/resources/org/apache/isis/core/metamodel/services/menubars/menubars.layout.xml b/core/metamodel/src/test/java/org/apache/isis/core/metamodel/services/menubars/menubars.layout.xml
similarity index 100%
rename from core/metamodel/src/test/resources/org/apache/isis/core/metamodel/services/menubars/menubars.layout.xml
rename to core/metamodel/src/test/java/org/apache/isis/core/metamodel/services/menubars/menubars.layout.xml