You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/07/21 00:51:50 UTC
Review Request 61015: Fixed cgroup device Entry.Selector major/minor
number type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61015/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, haosdent huang, Jie Yu, Kevin Klues, and Qian Zhang.
Repository: mesos
Description
-------
A cgroup device is identified by a major and a minor number. They
are 'unsigned int' type. A pair of <major:minor> represents a
'dev_t'. For details:
http://www.makelinux.net/ldd3/chp-3-sect-9
Diffs
-----
src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
Diff: https://reviews.apache.org/r/61015/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 61015: Fixed cgroup device Entry.Selector
major/minor number type.
Posted by Gilbert Song <so...@gmail.com>.
> On July 20, 2017, 5:56 p.m., Benjamin Mahler wrote:
> > I think you'll want to reference this page in your description: http://man7.org/linux/man-pages/man3/makedev.3.html
> >
> > The one you linked to seems to show MAJOR/MINOR returning `int` rather than `unsigned int`.
Makes sense. I will update. Thanks!
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61015/#review181085
-----------------------------------------------------------
On July 20, 2017, 5:51 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61015/
> -----------------------------------------------------------
>
> (Updated July 20, 2017, 5:51 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, haosdent huang, Jie Yu, Kevin Klues, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A cgroup device is identified by a major and a minor number. They
> are 'unsigned int' type. A pair of <major:minor> represents a
> 'dev_t'. For details:
> http://www.makelinux.net/ldd3/chp-3-sect-9
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
> src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
>
>
> Diff: https://reviews.apache.org/r/61015/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61015: Fixed cgroup device Entry.Selector
major/minor number type.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61015/#review181085
-----------------------------------------------------------
Ship it!
I think you'll want to reference this page in your description: http://man7.org/linux/man-pages/man3/makedev.3.html
The one you linked to seems to show MAJOR/MINOR returning `int` rather than `unsigned int`.
- Benjamin Mahler
On July 21, 2017, 12:51 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61015/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 12:51 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, haosdent huang, Jie Yu, Kevin Klues, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A cgroup device is identified by a major and a minor number. They
> are 'unsigned int' type. A pair of <major:minor> represents a
> 'dev_t'. For details:
> http://www.makelinux.net/ldd3/chp-3-sect-9
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
> src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
>
>
> Diff: https://reviews.apache.org/r/61015/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61015: Fixed cgroup device Entry.Selector
major/minor number type.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61015/#review181122
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On July 21, 2017, 12:51 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61015/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 12:51 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, haosdent huang, Jie Yu, Kevin Klues, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A cgroup device is identified by a major and a minor number. They
> are 'unsigned int' type. A pair of <major:minor> represents a
> 'dev_t'. For details:
> http://www.makelinux.net/ldd3/chp-3-sect-9
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
> src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
>
>
> Diff: https://reviews.apache.org/r/61015/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61015: Fixed cgroup device Entry.Selector
major/minor number type.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61015/#review181102
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On July 21, 2017, 8:51 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61015/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 8:51 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, haosdent huang, Jie Yu, Kevin Klues, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A cgroup device is identified by a major and a minor number. They
> are 'unsigned int' type. A pair of <major:minor> represents a
> 'dev_t'. For details:
> http://www.makelinux.net/ldd3/chp-3-sect-9
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
> src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
>
>
> Diff: https://reviews.apache.org/r/61015/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61015: Fixed cgroup device Entry.Selector
major/minor number type.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61015/#review181427
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60991, 60932, 60933, 60934, 61015]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On July 26, 2017, 1:03 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61015/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 1:03 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, haosdent huang, Jie Yu, Kevin Klues, and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A cgroup device is identified by a major and a minor number. They
> are 'unsigned int' type. A pair of <major:minor> represents a
> 'dev_t'. For details:
> http://man7.org/linux/man-pages/man3/makedev.3.html
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
> src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
>
>
> Diff: https://reviews.apache.org/r/61015/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61015: Fixed cgroup device Entry.Selector
major/minor number type.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61015/
-----------------------------------------------------------
(Updated July 25, 2017, 6:03 p.m.)
Review request for mesos, Benjamin Mahler, haosdent huang, Jie Yu, Kevin Klues, and Qian Zhang.
Repository: mesos
Description (updated)
-------
A cgroup device is identified by a major and a minor number. They
are 'unsigned int' type. A pair of <major:minor> represents a
'dev_t'. For details:
http://man7.org/linux/man-pages/man3/makedev.3.html
Diffs (updated)
-----
src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
Diff: https://reviews.apache.org/r/61015/diff/2/
Changes: https://reviews.apache.org/r/61015/diff/1-2/
Testing
-------
make check
Thanks,
Gilbert Song