You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2024/04/21 01:04:13 UTC

[PR] Add distinct aggregate tests to sqllogictest [datafusion]

Jefffrey opened a new pull request, #10158:
URL: https://github.com/apache/datafusion/pull/10158

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #2411
   
   Closes #2410
   
   Closes #2408
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Datafusion already supports these use cases. Just locking them into the test suite
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org


Re: [PR] Add distinct aggregate tests to sqllogictest [datafusion]

Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on PR #10158:
URL: https://github.com/apache/datafusion/pull/10158#issuecomment-2067881319

   > FYI we don't support this
   > 
   > ```
   > > select median(distinct "1"), median("1") from '/home/jeffrey/Downloads/data.csv';
   > This feature is not implemented: MEDIAN(DISTINCT) aggregations are not available
   > ```
   > 
   > But maybe can tackle as separate issue from those original issues 🤔
   > 
   > See [#10159 (comment)](https://github.com/apache/datafusion/issues/10159#issuecomment-2067873654)
   
   If it hasn't been implemented yet, we should add them to sqllogictest and return an error first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org


Re: [PR] Add distinct aggregate tests to sqllogictest [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #10158:
URL: https://github.com/apache/datafusion/pull/10158#issuecomment-2068004757

   Thanks @Jefffrey  and @Weijun-H and @jayzhan211  🚀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org


Re: [PR] Add distinct aggregate tests to sqllogictest [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10158:
URL: https://github.com/apache/datafusion/pull/10158#issuecomment-2067894822

   Done. Also I'll keep the original issues open.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org


Re: [PR] Add distinct aggregate tests to sqllogictest [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #10158:
URL: https://github.com/apache/datafusion/pull/10158


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org


Re: [PR] Add distinct aggregate tests to sqllogictest [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10158:
URL: https://github.com/apache/datafusion/pull/10158#issuecomment-2067880376

   FYI we don't support this
   
   ```
   > select median(distinct "1"), median("1") from '/home/jeffrey/Downloads/data.csv';
   This feature is not implemented: MEDIAN(DISTINCT) aggregations are not available
   ```
   
   But maybe can tackle as separate issue from those original issues :thinking: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org