You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Pradeep Kamath (JIRA)" <ji...@apache.org> on 2010/02/25 02:06:27 UTC
[jira] Created: (PIG-1259) ResourceFieldSchema.setSchema should not
allow a bag field without a Tuple as its only sub field (the tuple itself
can have a schema with > 1 subfields)
ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
---------------------------------------------------------------------------------------------------------------------------------------------------------
Key: PIG-1259
URL: https://issues.apache.org/jira/browse/PIG-1259
Project: Pig
Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Pradeep Kamath
Fix For: 0.7.0
Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1259) ResourceFieldSchema.setSchema should
not allow a bag field without a Tuple as its only sub field (the tuple
itself can have a schema with > 1 subfields)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838575#action_12838575 ]
Hadoop QA commented on PIG-1259:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12437025/PIG-1259-2.patch
against trunk revision 916065.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/223/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/223/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/223/console
This message is automatically generated.
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259-2.patch, PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1259) ResourceFieldSchema.setSchema should not
allow a bag field without a Tuple as its only sub field (the tuple itself
can have a schema with > 1 subfields)
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1259:
--------------------------------
Assignee: Pradeep Kamath
Status: Patch Available (was: Open)
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1259) ResourceFieldSchema.setSchema should
not allow a bag field without a Tuple as its only sub field (the tuple
itself can have a schema with > 1 subfields)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838146#action_12838146 ]
Hadoop QA commented on PIG-1259:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436939/PIG-1259.patch
against trunk revision 916065.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/220/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/220/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/220/console
This message is automatically generated.
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1259) ResourceFieldSchema.setSchema should not
allow a bag field without a Tuple as its only sub field (the tuple itself
can have a schema with > 1 subfields)
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1259:
--------------------------------
Attachment: PIG-1259-2.patch
Patch to address unit test failures - some tests had a missing try-catch block
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259-2.patch, PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1259) ResourceFieldSchema.setSchema should not
allow a bag field without a Tuple as its only sub field (the tuple itself
can have a schema with > 1 subfields)
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1259:
--------------------------------
Attachment: PIG-1259.patch
Attached patch adds validation as suggested in description
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1259) ResourceFieldSchema.setSchema should
not allow a bag field without a Tuple as its only sub field (the tuple
itself can have a schema with > 1 subfields)
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839008#action_12839008 ]
Daniel Dai commented on PIG-1259:
---------------------------------
+1
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259-2.patch, PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1259) ResourceFieldSchema.setSchema should not
allow a bag field without a Tuple as its only sub field (the tuple itself
can have a schema with > 1 subfields)
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1259:
--------------------------------
Status: Open (was: Patch Available)
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259-2.patch, PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PIG-1259) ResourceFieldSchema.setSchema should not
allow a bag field without a Tuple as its only sub field (the tuple itself
can have a schema with > 1 subfields)
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai closed PIG-1259.
---------------------------
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259-2.patch, PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1259) ResourceFieldSchema.setSchema should not
allow a bag field without a Tuple as its only sub field (the tuple itself
can have a schema with > 1 subfields)
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1259:
--------------------------------
Status: Patch Available (was: Open)
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259-2.patch, PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1259) ResourceFieldSchema.setSchema should not
allow a bag field without a Tuple as its only sub field (the tuple itself
can have a schema with > 1 subfields)
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pradeep Kamath updated PIG-1259:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Incompatible change, Reviewed]
Status: Resolved (was: Patch Available)
Patch committed.
> ResourceFieldSchema.setSchema should not allow a bag field without a Tuple as its only sub field (the tuple itself can have a schema with > 1 subfields)
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-1259
> URL: https://issues.apache.org/jira/browse/PIG-1259
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Pradeep Kamath
> Assignee: Pradeep Kamath
> Fix For: 0.7.0
>
> Attachments: PIG-1259-2.patch, PIG-1259.patch
>
>
> Currently Schema.getPigSchema(ResourceSchema) does not allow a bag field in the ResourceSchema with a subschema containing anything other than a tuple. The tuple itself can have a schema with > 1 subfields. This check should also be enforced in ResourceFieldSchema.setSchema()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.