[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21729: fix: allow adhoc query in chart columns

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #21729:
URL: https://github.com/apache/superset/pull/21729#discussion_r989682802


##########
superset/connectors/sqla/models.py:
##########
@@ -119,6 +119,7 @@
 from superset.superset_typing import (
     AdhocColumn,
     AdhocMetric,
+    Column,

Review Comment:
   ```
   Column as ColumnTyping
   ```



##########
superset/connectors/sqla/models.py:
##########
@@ -51,7 +51,7 @@
     and_,
     asc,
     Boolean,
-    Column,
+    Column as SqlaColumn,

Review Comment:
   from SQLAlchemy import `Column` is a convention in the current codebase, we should keep that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org