You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "riteshghorse (via GitHub)" <gi...@apache.org> on 2023/02/17 21:21:00 UTC
[GitHub] [beam] riteshghorse opened a new issue, #25547: [Task]: Add pytorch, onnx dependencies for integration tests
riteshghorse opened a new issue, #25547:
URL: https://github.com/apache/beam/issues/25547
### What needs to happen?
Currently the python post commits are skipping the integration tests for pytorch, onnx model handlers. Add the dependencies to enable these tests.
### Issue Priority
Priority: 3 (nice-to-have improvement)
### Issue Components
- [X] Component: Python SDK
- [ ] Component: Java SDK
- [ ] Component: Go SDK
- [ ] Component: Typescript SDK
- [ ] Component: IO connector
- [ ] Component: Beam examples
- [ ] Component: Beam playground
- [ ] Component: Beam katas
- [ ] Component: Website
- [ ] Component: Spark Runner
- [ ] Component: Flink Runner
- [ ] Component: Samza Runner
- [ ] Component: Twister2 Runner
- [ ] Component: Hazelcast Jet Runner
- [ ] Component: Google Cloud Dataflow Runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on issue #25547: [Task]: Add pytorch, onnx dependencies for integration tests
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on issue #25547:
URL: https://github.com/apache/beam/issues/25547#issuecomment-1435718984
Seems like tensorflow tests are failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on issue #25547: [Task]: Add pytorch, onnx dependencies for integration tests
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on issue #25547:
URL: https://github.com/apache/beam/issues/25547#issuecomment-1435716734
I think they are not getting skipped. They are not visible in Jenkins UI `Test Result`.
Commented at https://github.com/apache/beam/pull/25548#issuecomment-1435716414 but adding here as well for reference
the tests are actually running but not visible in the Jenkins UI. You can look in the console log and search for `InferencePostCommitIT` in python 37 https://github.com/apache/beam/blob/977e53104f493124101c8f06d63cca0ec0994990/build.gradle.kts#L447 and python 39 test suite https://github.com/apache/beam/blob/977e53104f493124101c8f06d63cca0ec0994990/build.gradle.kts#L476.
Console log: https://ci-beam.apache.org/job/beam_PostCommit_Python39/1480/consoleFull
The tests we see in the `Test Results` UI of jenkins is of the gradle task https://github.com/apache/beam/blob/977e53104f493124101c8f06d63cca0ec0994990/build.gradle.kts#L470. in the gradle task, we skip all the ML tests since they are run on different gradle task `PostCommitIT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on issue #25547: [Task]: Add pytorch, onnx dependencies for integration tests
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on issue #25547:
URL: https://github.com/apache/beam/issues/25547#issuecomment-1435718632
Also, for ONNX there is no gradle task to run IT tests so we can't see them in console logs. I will add it next week.
torch can be seen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on issue #25547: [Task]: Add pytorch, onnx dependencies for integration tests
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on issue #25547:
URL: https://github.com/apache/beam/issues/25547#issuecomment-1679880775
This task is obsolete as it was a problem with UI but tests were actually running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse closed issue #25547: [Task]: Add pytorch, onnx dependencies for integration tests
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse closed issue #25547: [Task]: Add pytorch, onnx dependencies for integration tests
URL: https://github.com/apache/beam/issues/25547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on issue #25547: [Task]: Add pytorch, onnx dependencies for integration tests
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on issue #25547:
URL: https://github.com/apache/beam/issues/25547#issuecomment-1436276720
https://ci-beam.apache.org/job/beam_PostCommit_Python310/496/
The postcommits are green now. Thanks @Abacn for merging the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on issue #25547: [Task]: Add pytorch, onnx dependencies for integration tests
Posted by "riteshghorse (via GitHub)" <gi...@apache.org>.
riteshghorse commented on issue #25547:
URL: https://github.com/apache/beam/issues/25547#issuecomment-1438726024
Oops I missed the `gs://` in older pr for path and had it https://github.com/apache/beam/pull/25496/files. Thanks for fixing it @AnandInguva
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org