[GitHub] [superset] michael-s-molina edited a comment on pull request #16876: fix: Removing parent filter causes incorrect state of child filter

[GitBox <gi...@apache.org>]

michael-s-molina edited a comment on pull request #16876:
URL: https://github.com/apache/superset/pull/16876#issuecomment-930051518


   > Hi @michael-s-molina. I found a problem with deleting and undoing a deletion on the fly without saving. As you can see in the video the child filter won't show as hierarchical after the parent filter has been removed and then added back again.
   > 
   >  Video.Game.Sales.1.mp4
   
   @geido I noticed that in my tests. It's related to the form `preserve={false}`.  I didn't change it because it's a minor problem and I know that you're investigating the `preserve={false}` in the undo PR follow-up so I preferred to wait for your conclusions. If in the end, if you remove the `preserve={false}`, this bug will be fixed. If not, I can fix it in a follow-up using a different strategy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org