[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6357: Add logs to the listLoadBalancerRuleInstances API

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6357:
URL: https://github.com/apache/cloudstack/pull/6357#discussion_r873451924


##########
api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java:
##########
@@ -97,7 +97,10 @@ public String getCommandName() {
     public void execute() {
         Pair<List<? extends UserVm>, List<String>> vmServiceMap =  _lbService.listLoadBalancerInstances(this);
         List<? extends UserVm> result = vmServiceMap.first();
+        s_logger.debug(String.format("A total of [%s] user VMs were obtained when listing the load balancer instances: [%s].", result.size(), result.toString()));

Review Comment:
   ```suggestion
           if (result != null && s_logger.isDebugEnabled()) {
               s_logger.debug(String.format("A total of [%s] user VMs were obtained when listing the load balancer instances: [%s].", result.size(), result.toString()));
           }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org